You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Adrian Crum <ad...@sandglass-software.com> on 2011/04/02 18:04:23 UTC
Re: svn commit: r1088014 - /ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java
How are those annotations useless? They suppress compiler warnings (The
Map references are not parameterized).
-Adrian
On 4/2/2011 5:14 AM, jleroux@apache.org wrote:
> Author: jleroux
> Date: Sat Apr 2 12:14:18 2011
> New Revision: 1088014
>
> URL: http://svn.apache.org/viewvc?rev=1088014&view=rev
> Log:
> Removes useless suppress warning annotations, fixes module name
>
> Modified:
> ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java
>
> Modified: ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java?rev=1088014&r1=1088013&r2=1088014&view=diff
> ==============================================================================
> --- ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java (original)
> +++ ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java Sat Apr 2 12:14:18 2011
> @@ -41,9 +41,8 @@ import freemarker.template.TemplateTrans
> */
> public class OfbizContentTransform implements TemplateTransformModel {
>
> - public final static String module = OfbizUrlTransform.class.getName();
> + public final static String module = OfbizContentTransform.class.getName();
>
> - @SuppressWarnings("unchecked")
> private static String getArg(Map args, String key) {
> String result = "";
> Object obj = args.get(key);
> @@ -63,7 +62,6 @@ public class OfbizContentTransform imple
> return result;
> }
>
> - @SuppressWarnings("unchecked")
> public Writer getWriter(final Writer out, Map args) {
> final StringBuilder buf = new StringBuilder();
> final String imgSize = OfbizContentTransform.getArg(args, "variant");
>
>
Re: svn commit: r1088014 - /ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java
Posted by Jacques Le Roux <ja...@les7arts.com>.
Eclipse 3.6 complained about them, see
http://wiki.event-b.org/index.php/Migration_to_Eclipse_3.6#.40SuppressWarnings.28.22unchecked.22.29_does_not_ignore_raw_types_warnings_anymore
Actually in this case nothing was required, you might check.
Also see "ant clean build": it's OK (with jdk1.6.0_22 which BTW is bad for 64bits server, needs 18 < or > 22)
D:\workspace\ofbizDev>"C:\Program Files\Java\jdk1.6.0_22\bin\java" -jar framework/base/lib/ant-launcher-1.7.1.jar -lib
framework/base/lib/ant clean build
Buildfile: build.xml
clean:
[subant] No sub-builds to iterate on
clean:
clean:
[delete] Deleting directory D:\workspace\ofbizDev\specialpurpose\ecommerce\build
[........]
clean:
[delete] Deleting directory D:\workspace\ofbizDev\framework\webapp\build
[........]
[echo] [clean] ========== Done Cleaning Framework ==========
[delete] Deleting: D:\workspace\ofbizDev\ofbiz.jar
[echo] [clean] ========== Done Cleaning ==========
ofbiz-init:
build:
[echo] [build] ========== Start Building (Compile) ==========
[........]
classes:
[javac16] Compiling 91 source files to D:\workspace\ofbizClean\framework\webapp\build\classes
jar:
[jar] Building jar: D:\workspace\ofbizClean\framework\webapp\build\lib\ofbiz-webapp.jar
[jar] Building jar: D:\workspace\ofbizClean\framework\webapp\build\lib\ofbiz-webapp-test.jar
init:
[........]
The only warnings we have are in
classes:
[javac16] Compiling 10 source files to D:\workspace\ofbizClean\framework\birt\build\classes
[javac16] D:\workspace\ofbizClean\framework\birt\src\org\ofbiz\birt\report\service\OFBizBirtViewerReportService.java:42: warning:
[deprecation] org.eclipse.birt.report.service.ReportEngineService.DummyRemot
eException in org.eclipse.birt.report.service.ReportEngineService has been deprecated
[javac16] import org.eclipse.birt.report.service.ReportEngineService.DummyRemoteException;
[javac16] ^
[javac16] D:\workspace\ofbizClean\framework\birt\src\org\ofbiz\birt\report\service\OFBizBirtViewerReportService.java:262: warning:
[deprecation] org.eclipse.birt.report.service.ReportEngineService.DummyRemo
teException in org.eclipse.birt.report.service.ReportEngineService has been deprecated
[javac16] private void throwDummyException(Exception e) throws DummyRemoteException {
[javac16] ^
[javac16] 2 warnings
Jacques
From: "Adrian Crum" <ad...@sandglass-software.com>
To: <de...@ofbiz.apache.org>
Sent: Saturday, April 02, 2011 6:04 PM
Subject: Re: svn commit: r1088014 - /ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java
> How are those annotations useless? They suppress compiler warnings (The Map references are not parameterized).
>
> -Adrian
>
> On 4/2/2011 5:14 AM, jleroux@apache.org wrote:
>> Author: jleroux
>> Date: Sat Apr 2 12:14:18 2011
>> New Revision: 1088014
>>
>> URL: http://svn.apache.org/viewvc?rev=1088014&view=rev
>> Log:
>> Removes useless suppress warning annotations, fixes module name
>>
>> Modified:
>> ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java
>>
>> Modified: ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java?rev=1088014&r1=1088013&r2=1088014&view=diff
>> ==============================================================================
>> --- ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java (original)
>> +++ ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java Sat Apr 2 12:14:18 2011
>> @@ -41,9 +41,8 @@ import freemarker.template.TemplateTrans
>> */
>> public class OfbizContentTransform implements TemplateTransformModel {
>>
>> - public final static String module = OfbizUrlTransform.class.getName();
>> + public final static String module = OfbizContentTransform.class.getName();
>>
>> - @SuppressWarnings("unchecked")
>> private static String getArg(Map args, String key) {
>> String result = "";
>> Object obj = args.get(key);
>> @@ -63,7 +62,6 @@ public class OfbizContentTransform imple
>> return result;
>> }
>>
>> - @SuppressWarnings("unchecked")
>> public Writer getWriter(final Writer out, Map args) {
>> final StringBuilder buf = new StringBuilder();
>> final String imgSize = OfbizContentTransform.getArg(args, "variant");
>>
>>