You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2017/12/21 22:36:27 UTC
[GitHub] merlimat commented on issue #1001: Shading in Pulsar jars
merlimat commented on issue #1001: Shading in Pulsar jars
URL: https://github.com/apache/incubator-pulsar/issues/1001#issuecomment-353475255
@sschepens We had many issues with people having conflicts with different protobuf or netty versions and taking long time to debug those at runtime.
I think shading by default is "nicer" to users. There is still the options to get unshaded client artifact by using `pulsar-client-original`. Do you think the option should be specified more prominently in the client documentation?
> I don't remember the last time I imported a library that was shaded.
Many libraries are actually doing that under the hood (eg: Netty, JCommander and many others).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services