You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/05/19 00:38:05 UTC
[GitHub] [dubbo-go] codecov-commenter commented on pull request #510: Ftr : add UnRegister and UnSubscribe for zookeeper Registry
codecov-commenter commented on pull request #510:
URL: https://github.com/apache/dubbo-go/pull/510#issuecomment-630507062
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/510?src=pr&el=h1) Report
> Merging [#510](https://codecov.io/gh/apache/dubbo-go/pull/510?src=pr&el=desc) into [feature/dubbo-2.7.5](https://codecov.io/gh/apache/dubbo-go/commit/24e7205ff5498c6f4eb780fe400426fe78000f9e&el=desc) will **increase** coverage by `0.19%`.
> The diff coverage is `69.54%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/510/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/510?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## feature/dubbo-2.7.5 #510 +/- ##
=======================================================
+ Coverage 66.38% 66.57% +0.19%
=======================================================
Files 184 199 +15
Lines 9717 10275 +558
=======================================================
+ Hits 6451 6841 +390
- Misses 2626 2776 +150
- Partials 640 658 +18
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/510?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [common/extension/event\_dispatcher.go](https://codecov.io/gh/apache/dubbo-go/pull/510/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9ldmVudF9kaXNwYXRjaGVyLmdv) | `0.00% <0.00%> (ø)` | |
| [common/extension/metadata\_report\_factory.go](https://codecov.io/gh/apache/dubbo-go/pull/510/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRhZGF0YV9yZXBvcnRfZmFjdG9yeS5nbw==) | `0.00% <0.00%> (ø)` | |
| [...ommon/observer/dispatcher/mock\_event\_dispatcher.go](https://codecov.io/gh/apache/dubbo-go/pull/510/diff?src=pr&el=tree#diff-Y29tbW9uL29ic2VydmVyL2Rpc3BhdGNoZXIvbW9ja19ldmVudF9kaXNwYXRjaGVyLmdv) | `0.00% <0.00%> (ø)` | |
| [common/rpc\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/510/diff?src=pr&el=tree#diff-Y29tbW9uL3JwY19zZXJ2aWNlLmdv) | `85.18% <0.00%> (-1.07%)` | :arrow_down: |
| [config/base\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/510/diff?src=pr&el=tree#diff-Y29uZmlnL2Jhc2VfY29uZmlnLmdv) | `64.14% <ø> (ø)` | |
| [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/510/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `69.01% <0.00%> (-4.13%)` | :arrow_down: |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/510/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `67.88% <0.00%> (-3.27%)` | :arrow_down: |
| [registry/nacos/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/510/diff?src=pr&el=tree#diff-cmVnaXN0cnkvbmFjb3MvcmVnaXN0cnkuZ28=) | `55.31% <0.00%> (-3.11%)` | :arrow_down: |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/510/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `51.09% <0.00%> (-0.29%)` | :arrow_down: |
| [common/observer/event.go](https://codecov.io/gh/apache/dubbo-go/pull/510/diff?src=pr&el=tree#diff-Y29tbW9uL29ic2VydmVyL2V2ZW50Lmdv) | `16.66% <16.66%> (ø)` | |
| ... and [38 more](https://codecov.io/gh/apache/dubbo-go/pull/510/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/510?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/510?src=pr&el=footer). Last update [24e7205...2699fcc](https://codecov.io/gh/apache/dubbo-go/pull/510?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org