You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2012/06/21 07:34:15 UTC
[Bug 53446] New: [PATCH] Fix some problems extracting PNGs
https://issues.apache.org/bugzilla/show_bug.cgi?id=53446
Priority: P2
Bug ID: 53446
Assignee: dev@poi.apache.org
Summary: [PATCH] Fix some problems extracting PNGs
Severity: normal
Classification: Unclassified
Reporter: luke@nuix.com
Hardware: PC
Status: NEW
Version: 3.9-dev
Component: POI Overall
Product: POI
Created attachment 28974
--> https://issues.apache.org/bugzilla/attachment.cgi?id=28974&action=edit
The patch to fix extraction problems.
HSLF had some code to chop off 16 bytes of "Mac data" from some PNGs; I found
samples of the same thing in Word and Excel so I've applied a similar fix to
those formats too.
Also fixed HSLF to look for the PNG header instead of using ImageIO to load up
the whole image.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 53446] [PATCH] Fix some problems extracting PNGs
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53446
--- Comment #5 from Luke Quinane <lu...@nuix.com> ---
Hi Yegor,
I'm a bit tied up at the moment with other things but I'll try to add some unit
tests in a week or so.
Cheers,
Luke
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 53446] [PATCH] Fix some problems extracting PNGs
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53446
Yegor Kozlov <ye...@dinom.ru> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #7 from Yegor Kozlov <ye...@dinom.ru> ---
Thanks for the patch, applied oin r1369263
Regards,
Yegor
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 53446] [PATCH] Fix some problems extracting PNGs
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53446
Yegor Kozlov <ye...@dinom.ru> changed:
What |Removed |Added
----------------------------------------------------------------------------
OS| |All
--- Comment #4 from Yegor Kozlov <ye...@dinom.ru> ---
Can you add some unit tests that assert that POI can read PNGs with "mac
headers"?
The patch looks good but I'm reluctant to apply it without tests.
Regards,
Yegor
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 53446] [PATCH] Fix some problems extracting PNGs
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53446
--- Comment #1 from Luke Quinane <lu...@nuix.com> ---
Created attachment 28975
--> https://issues.apache.org/bugzilla/attachment.cgi?id=28975&action=edit
Word document with the problem.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 53446] [PATCH] Fix some problems extracting PNGs
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53446
--- Comment #2 from Luke Quinane <lu...@nuix.com> ---
Created attachment 28976
--> https://issues.apache.org/bugzilla/attachment.cgi?id=28976&action=edit
Powerpoint document with the problem.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 53446] [PATCH] Fix some problems extracting PNGs
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53446
--- Comment #6 from Luke Quinane <lu...@nuix.com> ---
Created attachment 29110
--> https://issues.apache.org/bugzilla/attachment.cgi?id=29110&action=edit
Patch to add unit tests.
Here is a patch to add unit tests. I had to delete the test data out of the
patch because it was too big to upload to bugzilla. I just used each of the
three sample files attached previously.
Cheers,
Luke
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 53446] [PATCH] Fix some problems extracting PNGs
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53446
--- Comment #3 from Luke Quinane <lu...@nuix.com> ---
Created attachment 28977
--> https://issues.apache.org/bugzilla/attachment.cgi?id=28977&action=edit
Exce; document with the problem.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org