[GitHub] [openwhisk-runtime-nodejs] upgle commented on a diff in pull request #221: Bumping to gradle 6

[GitBox <gi...@apache.org>]

upgle commented on code in PR #221:
URL: https://github.com/apache/openwhisk-runtime-nodejs/pull/221#discussion_r936174947


##########
tests/build.gradle:
##########
@@ -34,9 +34,11 @@ tasks.withType(Test) {
 }
 
 dependencies {
-    compile "org.scala-lang:scala-library:${gradle.scala.version}"
-    compile "org.apache.openwhisk:openwhisk-tests:${gradle.openwhisk.version}:tests"
-    compile "org.apache.openwhisk:openwhisk-tests:${gradle.openwhisk.version}:test-sources"
+    implementation "junit:junit:4.11"

Review Comment:
   A parent project (openwhisk core) that uses `implementation` instead of `compile` no longer provides dependencies to child projects. It needs to re-add the required dependencies for testing with `implementation` in sub project.
   
   related documents:
   - https://docs.gradle.org/current/userguide/upgrading_version_5.html#dependencies_should_no_longer_be_declared_using_the_compile_and_runtime_configurations
   - https://docs.gradle.org/current/userguide/declaring_dependencies.html



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org