You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2016/11/29 22:13:41 UTC
Re: Review Request 53938: Added helper to get the io switchboard
server address.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53938/#review157339
-----------------------------------------------------------
Ship it!
I rebased it for you as BenH removed the unix::Address constructor.
- Jie Yu
On Nov. 24, 2016, 5:07 a.m., Kevin Klues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53938/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2016, 5:07 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-6467
> https://issues.apache.org/jira/browse/MESOS-6467
>
>
> Repository: mesos
>
>
> Description
> -------
>
> For now, the io switchboard server will always hosted on a unix domain
> socket. The path limit for a unix domain socket is 100 bytes, so we
> can't just use a file in our runtime directory as the socket file we
> connect to. Instead, we store the path to the socket file in our
> runtime directory and read it from there.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/paths.hpp 883cc263c58cf24c3e515dad7bda97efd32f2f17
> src/slave/containerizer/mesos/paths.cpp 361307f21422c046672fb7ed29add8fe7e5c4354
>
> Diff: https://reviews.apache.org/r/53938/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Kevin Klues
>
>