You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Thomas Mueller (JIRA)" <ji...@apache.org> on 2012/11/22 12:56:58 UTC
[jira] [Created] (JCR-3460) PropertyIndex uses TraversingCursor but
should not
Thomas Mueller created JCR-3460:
-----------------------------------
Summary: PropertyIndex uses TraversingCursor but should not
Key: JCR-3460
URL: https://issues.apache.org/jira/browse/JCR-3460
Project: Jackrabbit Content Repository
Issue Type: Bug
Components: query
Reporter: Thomas Mueller
Assignee: Thomas Mueller
The org.apache.jackrabbit.oak.plugins.index.property.PropertyIndex uses the traversing cursor (that traverses over the whole repository) when there is no index. This is not how the index mechanism is supposed to work: if there is no property index, then the cost function of the property index should return infinity or max value, so that the property index isn't used.
According to my test the PropertyIndex never really falls back to traversing, so this might just be "defensive programming". However, in this case it would be better if the code would throw an exception, otherwise we risk not seeing the bug in the PropertyIndex cost method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3460) PropertyIndex uses TraversingCursor
but should not
Posted by "Thomas Mueller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502734#comment-13502734 ]
Thomas Mueller commented on JCR-3460:
-------------------------------------
Revision 1412513
> PropertyIndex uses TraversingCursor but should not
> --------------------------------------------------
>
> Key: JCR-3460
> URL: https://issues.apache.org/jira/browse/JCR-3460
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: query
> Reporter: Thomas Mueller
> Assignee: Thomas Mueller
>
> The org.apache.jackrabbit.oak.plugins.index.property.PropertyIndex uses the traversing cursor (that traverses over the whole repository) when there is no index. This is not how the index mechanism is supposed to work: if there is no property index, then the cost function of the property index should return infinity or max value, so that the property index isn't used.
> According to my test the PropertyIndex never really falls back to traversing, so this might just be "defensive programming". However, in this case it would be better if the code would throw an exception, otherwise we risk not seeing the bug in the PropertyIndex cost method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3460) PropertyIndex uses TraversingCursor
but should not
Posted by "Thomas Mueller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502736#comment-13502736 ]
Thomas Mueller commented on JCR-3460:
-------------------------------------
The NodeTypeIndex also currently uses the TraversingCursor
> PropertyIndex uses TraversingCursor but should not
> --------------------------------------------------
>
> Key: JCR-3460
> URL: https://issues.apache.org/jira/browse/JCR-3460
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: query
> Reporter: Thomas Mueller
> Assignee: Thomas Mueller
>
> The org.apache.jackrabbit.oak.plugins.index.property.PropertyIndex uses the traversing cursor (that traverses over the whole repository) when there is no index. This is not how the index mechanism is supposed to work: if there is no property index, then the cost function of the property index should return infinity or max value, so that the property index isn't used.
> According to my test the PropertyIndex never really falls back to traversing, so this might just be "defensive programming". However, in this case it would be better if the code would throw an exception, otherwise we risk not seeing the bug in the PropertyIndex cost method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (JCR-3460) PropertyIndex uses TraversingCursor
but should not
Posted by "Thomas Mueller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Mueller resolved JCR-3460.
---------------------------------
Resolution: Fixed
Revision 1412514
> PropertyIndex uses TraversingCursor but should not
> --------------------------------------------------
>
> Key: JCR-3460
> URL: https://issues.apache.org/jira/browse/JCR-3460
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: query
> Reporter: Thomas Mueller
> Assignee: Thomas Mueller
>
> The org.apache.jackrabbit.oak.plugins.index.property.PropertyIndex uses the traversing cursor (that traverses over the whole repository) when there is no index. This is not how the index mechanism is supposed to work: if there is no property index, then the cost function of the property index should return infinity or max value, so that the property index isn't used.
> According to my test the PropertyIndex never really falls back to traversing, so this might just be "defensive programming". However, in this case it would be better if the code would throw an exception, otherwise we risk not seeing the bug in the PropertyIndex cost method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira