You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "clolov (via GitHub)" <gi...@apache.org> on 2023/02/16 11:57:45 UTC
[GitHub] [kafka] clolov opened a new pull request, #13259: MINOR: Simplify JUnit assertions in src; remove accidental unnecessary code in src
clolov opened a new pull request, #13259:
URL: https://github.com/apache/kafka/pull/13259
I ran IntelliJ IDEA's Code Inspection and corrected occurrences of the following:
* https://www.jetbrains.com/help/idea/list-of-java-inspections.html#inheritance-issues (method is identical to its super method)
* https://www.jetbrains.com/help/idea/list-of-java-inspections.html#imports (unused import)
It is safe to remove said methods because they are already defined upward in the hierarchy chain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mimaison merged pull request #13259: MINOR: Remove accidental unnecessary code in src
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison merged PR #13259:
URL: https://github.com/apache/kafka/pull/13259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mimaison commented on pull request #13259: MINOR: Simplify JUnit assertions in src; remove accidental unnecessary code in src
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on PR #13259:
URL: https://github.com/apache/kafka/pull/13259#issuecomment-1440413003
I checked the clients and connect changes and they look good. I think some of the streams changes could be debatable (not sure if they want to keep some of the comments) so I'll let someone working on streams review them. @ableegoldman @guozhangwang can you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] clolov commented on pull request #13259: MINOR: Simplify JUnit assertions in src; remove accidental unnecessary code in src
Posted by "clolov (via GitHub)" <gi...@apache.org>.
clolov commented on PR #13259:
URL: https://github.com/apache/kafka/pull/13259#issuecomment-1440295776
Hello @mimaison, would you have the time to review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] clolov commented on pull request #13259: MINOR: Remove accidental unnecessary code in src
Posted by "clolov (via GitHub)" <gi...@apache.org>.
clolov commented on PR #13259:
URL: https://github.com/apache/kafka/pull/13259#issuecomment-1525212172
Great, thank you, I will address this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mimaison commented on pull request #13259: MINOR: Remove accidental unnecessary code in src
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on PR #13259:
URL: https://github.com/apache/kafka/pull/13259#issuecomment-1519845506
Thanks for the updates!
There's a spotbugs failure:
```
Bug type EQ_DOESNT_OVERRIDE_EQUALS
In class org.apache.kafka.connect.runtime.InternalSinkRecord
EQ_DOESNT_OVERRIDE_EQUALS: Class doesn't override equals in superclass
This class extends a class that defines an equals method and adds fields, but doesn't define an equals method itself. Thus, equality on instances of this class will ignore the identity of the subclass and the added fields. Be sure this is what is intended, and that you don't need to override the equals method. Even if you don't need to override the equals method, consider overriding it anyway to document the fact that the equals method for the subclass just return the result of invoking super.equals(o).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org