You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/06/11 14:00:22 UTC
[GitHub] [nifi] tpalfy opened a new pull request #4329: Nifi 7442 Add CLI commands to the registry for handling users, groups and policies
tpalfy opened a new pull request #4329:
URL: https://github.com/apache/nifi/pull/4329
https://issues.apache.org/jira/browse/NIFI-7442
New commands were added to the CLI to be able to create/update users, user groups and access policies in NiFi Registry. As NiFi depends on released Registry, some code temporarily takes place in NiFi which should be moved to the Registry in the long term. Also, this comes with some code duplication as well (which will be removed in a later point too).
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `master`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] bbende commented on pull request #4329: Nifi 7442 Add CLI commands to the registry for handling users, groups and policies
Posted by GitBox <gi...@apache.org>.
bbende commented on pull request #4329:
URL: https://github.com/apache/nifi/pull/4329#issuecomment-643375072
Overall this looks good and all commands working as expected. I'm going to commit this and make the small docs update as part of the commit, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] asfgit closed pull request #4329: Nifi 7442 Add CLI commands to the registry for handling users, groups and policies
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4329:
URL: https://github.com/apache/nifi/pull/4329
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] bbende commented on a change in pull request #4329: Nifi 7442 Add CLI commands to the registry for handling users, groups and policies
Posted by GitBox <gi...@apache.org>.
bbende commented on a change in pull request #4329:
URL: https://github.com/apache/nifi/pull/4329#discussion_r439063970
##########
File path: nifi-docs/src/main/asciidoc/toolkit-guide.adoc
##########
@@ -106,6 +106,12 @@ The following are available commands:
registry import-flow-version
registry sync-flow-versions
registry transfer-flow-version
+ registry create-user
+ registry update-user
+ registry create-user-group
+ registry update-user-group
+ registry create-policy
Review comment:
Lets update this to be 'get-policy' since we got rid of create and folded into update.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org