You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/12/20 13:19:45 UTC
[GitHub] [pulsar] lhotari opened a new pull request, #19006: [fix][test] Fix flaky test PulsarMultiListenersWithoutInternalListenerNameTest.setup
lhotari opened a new pull request, #19006:
URL: https://github.com/apache/pulsar/pull/19006
Fixes #19005
### Motivation
See #19005
### Modifications
Change free port allocation so that both ports are detected at once. Use SO_REUSEADDR socket option for PortForwarder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari merged pull request #19006: [fix][test] Fix flaky test PulsarMultiListenersWithoutInternalListenerNameTest.setup
Posted by GitBox <gi...@apache.org>.
lhotari merged PR #19006:
URL: https://github.com/apache/pulsar/pull/19006
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #19006: [fix][test] Fix flaky test PulsarMultiListenersWithoutInternalListenerNameTest.setup
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #19006:
URL: https://github.com/apache/pulsar/pull/19006#issuecomment-1359340284
@lhotari Please add the following content to your PR description and select a checkbox:
```
- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #19006: [fix][test] Fix flaky test PulsarMultiListenersWithoutInternalListenerNameTest.setup
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #19006:
URL: https://github.com/apache/pulsar/pull/19006#issuecomment-1359432479
# [Codecov](https://codecov.io/gh/apache/pulsar/pull/19006?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19006](https://codecov.io/gh/apache/pulsar/pull/19006?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49667e6) into [master](https://codecov.io/gh/apache/pulsar/commit/22866bd19c231e85ddff4acee4dad1f895cbbc72?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (22866bd) will **increase** coverage by `0.57%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/pulsar/pull/19006?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #19006 +/- ##
============================================
+ Coverage 45.92% 46.49% +0.57%
- Complexity 10104 10473 +369
============================================
Files 680 706 +26
Lines 66758 69004 +2246
Branches 7147 7392 +245
============================================
+ Hits 30660 32085 +1425
- Misses 32680 33321 +641
- Partials 3418 3598 +180
```
| Flag | Coverage Δ | |
|---|---|---|
| unittests | `46.49% <ø> (+0.57%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pulsar/pull/19006?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rvice/schema/KeyValueSchemaCompatibilityCheck.java](https://codecov.io/gh/apache/pulsar/pull/19006/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL3NjaGVtYS9LZXlWYWx1ZVNjaGVtYUNvbXBhdGliaWxpdHlDaGVjay5qYXZh) | `21.62% <0.00%> (-45.95%)` | :arrow_down: |
| [.../apache/pulsar/broker/loadbalance/LoadManager.java](https://codecov.io/gh/apache/pulsar/pull/19006/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9sb2FkYmFsYW5jZS9Mb2FkTWFuYWdlci5qYXZh) | `61.11% <0.00%> (-16.67%)` | :arrow_down: |
| [...pulsar/broker/service/PulsarCommandSenderImpl.java](https://codecov.io/gh/apache/pulsar/pull/19006/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL1B1bHNhckNvbW1hbmRTZW5kZXJJbXBsLmphdmE=) | `68.20% <0.00%> (-10.26%)` | :arrow_down: |
| [.../pulsar/broker/service/SharedConsumerAssignor.java](https://codecov.io/gh/apache/pulsar/pull/19006/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL1NoYXJlZENvbnN1bWVyQXNzaWdub3IuamF2YQ==) | `68.51% <0.00%> (-9.26%)` | :arrow_down: |
| [...balance/impl/SimpleResourceAllocationPolicies.java](https://codecov.io/gh/apache/pulsar/pull/19006/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9sb2FkYmFsYW5jZS9pbXBsL1NpbXBsZVJlc291cmNlQWxsb2NhdGlvblBvbGljaWVzLmphdmE=) | `48.57% <0.00%> (-5.72%)` | :arrow_down: |
| [...tent/PersistentDispatcherSingleActiveConsumer.java](https://codecov.io/gh/apache/pulsar/pull/19006/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL3BlcnNpc3RlbnQvUGVyc2lzdGVudERpc3BhdGNoZXJTaW5nbGVBY3RpdmVDb25zdW1lci5qYXZh) | `55.48% <0.00%> (-5.65%)` | :arrow_down: |
| [...g/apache/pulsar/client/impl/ConnectionHandler.java](https://codecov.io/gh/apache/pulsar/pull/19006/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL0Nvbm5lY3Rpb25IYW5kbGVyLmphdmE=) | `50.00% <0.00%> (-5.32%)` | :arrow_down: |
| [...ction/buffer/impl/TransactionBufferClientImpl.java](https://codecov.io/gh/apache/pulsar/pull/19006/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci90cmFuc2FjdGlvbi9idWZmZXIvaW1wbC9UcmFuc2FjdGlvbkJ1ZmZlckNsaWVudEltcGwuamF2YQ==) | `76.74% <0.00%> (-4.66%)` | :arrow_down: |
| [.../buffer/impl/TransactionBufferClientStatsImpl.java](https://codecov.io/gh/apache/pulsar/pull/19006/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci90cmFuc2FjdGlvbi9idWZmZXIvaW1wbC9UcmFuc2FjdGlvbkJ1ZmZlckNsaWVudFN0YXRzSW1wbC5qYXZh) | `82.00% <0.00%> (-4.00%)` | :arrow_down: |
| [...pulsar/broker/TransactionMetadataStoreService.java](https://codecov.io/gh/apache/pulsar/pull/19006/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9UcmFuc2FjdGlvbk1ldGFkYXRhU3RvcmVTZXJ2aWNlLmphdmE=) | `58.51% <0.00%> (-3.94%)` | :arrow_down: |
| ... and [54 more](https://codecov.io/gh/apache/pulsar/pull/19006/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org