You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/12/24 07:38:38 UTC
[GitHub] [cloudstack] shwstppr opened a new pull request #5809: ui: fix add network offering for vpc
shwstppr opened a new pull request #5809:
URL: https://github.com/apache/cloudstack/pull/5809
### Description
Fixes issues with form related to supported services provider and router service offering when offering to be created for VPC.
Fixes #5807
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5809: ui: fix add network offering for vpc
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5809:
URL: https://github.com/apache/cloudstack/pull/5809#issuecomment-1000826804
@shwstppr I have a PR to fix the problem you have when changing the VPC selection. you can take a look and merge it here. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5809: ui: fix add network offering for vpc
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5809:
URL: https://github.com/apache/cloudstack/pull/5809#issuecomment-1000705381
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5809 (SL-JID-934)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5809: ui: fix add network offering for vpc
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5809:
URL: https://github.com/apache/cloudstack/pull/5809#issuecomment-1002524075
@Pearl1594 can you please try now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #5809: ui: fix add network offering for vpc
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5809:
URL: https://github.com/apache/cloudstack/pull/5809#issuecomment-1002393955
@shwstppr I notice there to be an issue when we toggle the VPC switch in the network offering form, i.e., when it is turned on, and we check the services to be supported, it still lists VirtualRouter:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5809: ui: fix add network offering for vpc
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5809:
URL: https://github.com/apache/cloudstack/pull/5809#issuecomment-1001816098
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5809: ui: fix add network offering for vpc
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5809:
URL: https://github.com/apache/cloudstack/pull/5809#issuecomment-1000703034
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on a change in pull request #5809: ui: fix add network offering for vpc
Posted by GitBox <gi...@apache.org>.
utchoang commented on a change in pull request #5809:
URL: https://github.com/apache/cloudstack/pull/5809#discussion_r774951616
##########
File path: ui/src/components/CheckBoxSelectPair.vue
##########
@@ -97,12 +96,21 @@ export default {
data () {
return {
checked: false,
- selectedOption: null
+ selectedOption: null,
+ selectOptionsTimer: null
}
},
created () {
this.checked = this.defaultCheckBoxValue
},
+ watch: {
+ selectOptions () {
+ clearTimeout(this.selectOptionsTimer)
+ this.selectOptionsTimer = setTimeout(() => {
+ this.handleSelectOptionsUpdated()
Review comment:
@shwstppr In my opinion, instead of changing the choice of options according to VPC, we can reset those options to null/blank to avoid repetition causing form crashes. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5809: ui: fix add network offering for vpc
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5809:
URL: https://github.com/apache/cloudstack/pull/5809#issuecomment-1001817140
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5809 (SL-JID-941)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5809: ui: fix add network offering for vpc
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5809:
URL: https://github.com/apache/cloudstack/pull/5809#issuecomment-1001816055
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5809: ui: fix add network offering for vpc
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5809:
URL: https://github.com/apache/cloudstack/pull/5809#issuecomment-1002447894
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5809 (SL-JID-948)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on a change in pull request #5809: ui: fix add network offering for vpc
Posted by GitBox <gi...@apache.org>.
utchoang commented on a change in pull request #5809:
URL: https://github.com/apache/cloudstack/pull/5809#discussion_r774951616
##########
File path: ui/src/components/CheckBoxSelectPair.vue
##########
@@ -97,12 +96,21 @@ export default {
data () {
return {
checked: false,
- selectedOption: null
+ selectedOption: null,
+ selectOptionsTimer: null
}
},
created () {
this.checked = this.defaultCheckBoxValue
},
+ watch: {
+ selectOptions () {
+ clearTimeout(this.selectOptionsTimer)
+ this.selectOptionsTimer = setTimeout(() => {
+ this.handleSelectOptionsUpdated()
Review comment:
@shwstppr In my opinion, instead of changing the choice of options according to VPC, we can reset those options to null/blank to avoid repetition causing form crashes. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5809: ui: fix add network offering for vpc
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5809:
URL: https://github.com/apache/cloudstack/pull/5809#issuecomment-1002445815
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5809: ui: fix add network offering for vpc
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5809:
URL: https://github.com/apache/cloudstack/pull/5809#issuecomment-1002445415
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5809: ui: fix add network offering for vpc
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5809:
URL: https://github.com/apache/cloudstack/pull/5809#issuecomment-1000703528
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud merged pull request #5809: ui: fix add network offering for vpc
Posted by GitBox <gi...@apache.org>.
rohityadavcloud merged pull request #5809:
URL: https://github.com/apache/cloudstack/pull/5809
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 edited a comment on pull request #5809: ui: fix add network offering for vpc
Posted by GitBox <gi...@apache.org>.
Pearl1594 edited a comment on pull request #5809:
URL: https://github.com/apache/cloudstack/pull/5809#issuecomment-1002393955
@shwstppr I notice there to be an issue when we toggle the VPC switch in the network offering form, i.e., when it is turned on, and we check the services to be supported, it still lists VirtualRouter (The cache was cleared prior to verifying the fix):
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org