[GitHub] [flink] TisonKun opened a new pull request #9940: [FLINK-14434][coordination] Dispatcher#createJobManagerRunner returns on creation succeed

[GitBox <gi...@apache.org>]

TisonKun opened a new pull request #9940: [FLINK-14434][coordination] Dispatcher#createJobManagerRunner returns on creation succeed
URL: https://github.com/apache/flink/pull/9940
 
 
   ## What is the purpose of the change
   
   Fixes a race condition described detailedly in [FLINK-14434](https://issues.apache.org/jira/browse/FLINK-14434#).
   
   ## Brief change log
   
   Let `Dispatcher#createJobManagerRunner` returns on creation succeed.
   
   
   ## Verifying this change
   
   I think this change is straightforward and current behavior doesn't break guarded by existing tests. The diff attached on corresponding JIRA can reproduce the issue but I'm afraid it is always invasive to emulate this case(add a debug latch between `jobManagerRunner.start` and `return` for testing hook in my mind). Due to the change is straightforward and easy to reason, I tend to avoid invasive testing hook.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services