[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3049: ARTEMIS-2681 timestamp not set on notif msgs

[GitBox <gi...@apache.org>]

clebertsuconic commented on a change in pull request #3049: ARTEMIS-2681 timestamp not set on notif msgs
URL: https://github.com/apache/activemq-artemis/pull/3049#discussion_r398156316
 
 

 ##########
 File path: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/SecurityNotificationTest.java
 ##########
 @@ -155,6 +163,8 @@ public void testCONSUMER_CREATED() throws Exception {
       Assert.assertEquals("guest", notifications[0].getObjectProperty(ManagementHelper.HDR_VALIDATED_USER).toString());
       Assert.assertEquals(address.toString(), notifications[0].getObjectProperty(ManagementHelper.HDR_ADDRESS).toString());
       Assert.assertEquals(SimpleString.toSimpleString("unavailable"), notifications[0].getSimpleStringProperty(ManagementHelper.HDR_CERT_SUBJECT_DN));
+      Assert.assertTrue(notifications[0].getTimestamp() >= start);
+      Assert.assertTrue((Long) notifications[0].getObjectProperty(ManagementHelper.HDR_NOTIFICATION_TIMESTAMP) >= start);
 
 Review comment:
   shouldn't we assert for == .getTimestamp()? given the way it's implemented?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services