You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by to...@apache.org on 2017/06/09 00:12:31 UTC
kudu git commit: benchmarks: add set -o pipefail
Repository: kudu
Updated Branches:
refs/heads/master 9ae11e6d8 -> 557f19ea4
benchmarks: add set -o pipefail
It seems that our automated benchmarks job was failing to build for the
last several days, but we didn't notice because it didn't use
'pipefail'. Thus the 'make | tee build.log' failure didn't actually
cause the script to exit with a bad status code, and we kept running the
binaries from a previous revision.
Change-Id: I6ab66e85cf39c6513da61e472c85e34da77205fc
Reviewed-on: http://gerrit.cloudera.org:8080/7123
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Todd Lipcon <to...@apache.org>
Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/557f19ea
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/557f19ea
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/557f19ea
Branch: refs/heads/master
Commit: 557f19ea40d7910cbac004a2b45a1949c90f30cc
Parents: 9ae11e6
Author: Todd Lipcon <to...@cloudera.com>
Authored: Thu Jun 8 15:35:13 2017 -0700
Committer: Todd Lipcon <to...@apache.org>
Committed: Thu Jun 8 23:13:30 2017 +0000
----------------------------------------------------------------------
src/kudu/scripts/benchmarks.sh | 3 +++
1 file changed, 3 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kudu/blob/557f19ea/src/kudu/scripts/benchmarks.sh
----------------------------------------------------------------------
diff --git a/src/kudu/scripts/benchmarks.sh b/src/kudu/scripts/benchmarks.sh
index 949099c..1d7cfef 100755
--- a/src/kudu/scripts/benchmarks.sh
+++ b/src/kudu/scripts/benchmarks.sh
@@ -27,6 +27,9 @@
# Jenkins job: http://sandbox.jenkins.cloudera.com/job/kudu-benchmarks
########################################################################
+# Fail the job if any part fails, even when piping through 'tee', etc.
+set -o pipefail
+
################################################################
# Constants
################################################################