[GitHub] [ratis] hanishakoneru commented on a change in pull request #573: RATIS-1481. make state upgradate in notifyStateMachineToInstallSnapshot serialized

[GitBox <gi...@apache.org>]

hanishakoneru commented on a change in pull request #573:
URL: https://github.com/apache/ratis/pull/573#discussion_r825200168



##########
File path: ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerImpl.java
##########
@@ -1561,7 +1561,8 @@ private InstallSnapshotReplyProto installSnapshotImpl(InstallSnapshotRequestProt
     }
 
     if (reply != null) {
-      if (request.hasLastRaftConfigurationLogEntryProto()) {
+      if (request.hasLastRaftConfigurationLogEntryProto() && reply.getResult() ==
+              InstallSnapshotResult.SNAPSHOT_INSTALLED) {

Review comment:
       SNAPSHOT_INSTALLED result is returned when SM is notified to install snapshot. For the case when snapshot is sent as part of installSnapshot request by Ratis,  SUCCESS is returned as the result. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org