You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/04/20 14:18:38 UTC
[GitHub] [airflow] dimonchik-suvorov opened a new pull request #8473: [AIRFLOW-8472]: `PATCH` for Databricks hook `_do_api_call`
dimonchik-suvorov opened a new pull request #8473:
URL: https://github.com/apache/airflow/pull/8473
Support of `PATCH` for Databricks hook `_do_api_call` function
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on issue #8473: [AIRFLOW-8472]: `PATCH` for Databricks hook `_do_api_call`
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #8473:
URL: https://github.com/apache/airflow/pull/8473#issuecomment-616584394
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] houqp commented on issue #8473: [AIRFLOW-8472]: `PATCH` for Databricks hook `_do_api_call`
Posted by GitBox <gi...@apache.org>.
houqp commented on issue #8473:
URL: https://github.com/apache/airflow/pull/8473#issuecomment-616619449
For context, databricks has a beta API that uses PATCH method. Having this change in upstream makes easier for us to implement support for that. Once the API is out of beta, we will contribute that to the databricks hook as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #8473: [AIRFLOW-8472]: `PATCH` for Databricks hook `_do_api_call`
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #8473:
URL: https://github.com/apache/airflow/pull/8473#issuecomment-620189429
Great ! thanks @dimonchik-suvorov !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimonchik-suvorov commented on pull request #8473: [AIRFLOW-8472]: `PATCH` for Databricks hook `_do_api_call`
Posted by GitBox <gi...@apache.org>.
dimonchik-suvorov commented on pull request #8473:
URL: https://github.com/apache/airflow/pull/8473#issuecomment-619922105
> Can you please add a test for it?
There wasn't initial test for methods check, but yes, I can do that
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org