[GitHub] [pulsar] rdhabalia commented on a change in pull request #5710: Add publish rate limit for each broker to avoid OOM

[GitBox <gi...@apache.org>]

rdhabalia commented on a change in pull request #5710: Add publish rate limit for each broker to avoid OOM
URL: https://github.com/apache/pulsar/pull/5710#discussion_r350478500
 
 

 ##########
 File path: conf/broker.conf
 ##########
 @@ -175,9 +175,21 @@ maxUnackedMessagesPerBroker=0
 # limit/2 messages
 maxUnackedMessagesPerSubscriptionOnBrokerBlocked=0.16
 
-# Tick time to schedule task that checks publish rate limiting across all topics  
-# (Disable publish throttling with value 0)
-publisherThrottlingTickTimeMillis=10
+# Tick time to schedule task that checks topic publish rate limiting across all topics
+# Reducing to lower value can give more accuracy while throttling publish but
+# it uses more CPU to perform frequent check. (Disable publish throttling with value 0)
+topicPublisherThrottlingTickTimeMillis=10
+
+# Tick time to schedule task that checks broker publish rate limiting across all topics
+# Reducing to lower value can give more accuracy while throttling publish but
+# it uses more CPU to perform frequent check. (Disable publish throttling with value 0)
+brokerPublisherThrPottlingTickTimeMillis=50
+
+# Max Rate(in 1 seconds) of Message allowed to publish for a broker if broker publish rate limiting enabled
+brokerPublisherThrottlingMaxMessageRate=-1
 
 Review comment:
   can we make 0 to disable and also add into comment for disable instruction.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services