[GitHub] [hive] dengzhhu653 commented on a diff in pull request #3555: Improve LDAP auth to support include generic user filters (Naveen Gan…

[GitBox <gi...@apache.org>]

dengzhhu653 commented on code in PR #3555:
URL: https://github.com/apache/hive/pull/3555#discussion_r962796572


##########
service/src/java/org/apache/hive/service/auth/ldap/CustomQueryFilterFactory.java:
##########
@@ -76,6 +76,19 @@ public void apply(DirSearch client, String user) throws AuthenticationException
           }
         }
       }
+
+      // try a generic user search
+      String userSearchQuery = query.replace("{0}", user);

Review Comment:
   if the query does not contain '{0}',  the `userSearchQuery` would be the same as `query`, which makes TestLdapAtnProviderWithMiniDS#testCustomQueryNegative fail in this case. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org