You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/05/27 04:16:21 UTC

[GitHub] [arrow] BryanCutler commented on a change in pull request #7271: ARROW-8940: [Java] Fix the performance degradation of integration tests

BryanCutler commented on a change in pull request #7271:
URL: https://github.com/apache/arrow/pull/7271#discussion_r430837506



##########
File path: java/memory/src/main/java/org/apache/arrow/memory/BaseAllocator.java
##########
@@ -42,11 +42,21 @@
 
   public static final String DEBUG_ALLOCATOR = "arrow.memory.debug.allocator";
   public static final int DEBUG_LOG_LENGTH = 6;
-  public static final boolean DEBUG = AssertionUtil.isAssertionsEnabled() ||
-      Boolean.parseBoolean(System.getProperty(DEBUG_ALLOCATOR, "false"));
+  public static final boolean DEBUG;
   private static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(BaseAllocator.class);
   public static final Config DEFAULT_CONFIG = ImmutableConfig.builder().build();
 
+  static {
+    // the system property takes precedence.

Review comment:
       It seems correct to me for the system property to have precedence




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org