You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Filip Maj <fi...@adobe.com> on 2013/01/21 19:07:59 UTC
mobile spec pass rate sizable drop on android
Hey everyone,
Working over the weekend on the ci dashboard I noticed that the pass rate
on android for mobile-spec dropped from ~95% to ~85%. It looks like the
majority of failures are due to new tests for the File slice stuff that
was added recently, perhaps also related to the Blob stuff.
If you head to ci.cordova.io and click on the outer pie chart pieces
(representing individual devices) you'll see a list of failures on
particular devices.
It looks like some of this stuff is failing on iOS too (there's a Blob
constructor failure), but there is only one failure on iOS vs. 35+ on
Android.
Additionally, this is just on two platforms. Not sure what the situation
is on BlackBerry, WP, and our other supported platforms, but I'm assuming
no work was done on the new APIs for these platforms.
Andrew/Michal/Braden you guys were working on this stuff, ya? Are we going
to ship incomplete slice and blob implementations for 2.4.0rc1? I don't
care if we do, but I do care about cross-platform parity for new features
being shipped, and I'm concerned there is no plan for that with this new
File API addition.
Re: mobile spec pass rate sizable drop on android
Posted by Tim Kim <ti...@gmail.com>.
>
> The relevant bug for it is here:
> https://issues.apache.org/jira/browse/CB-2167
> There are sub-bugs for BB and WP. Not sure if anyone has the intention of
> addressing this for this release?
I've been busy working on some plugman stuff so I won't be able to get to
the BB one for this release.
Re: mobile spec pass rate sizable drop on android
Posted by Filip Maj <fi...@adobe.com>.
On 1/21/13 10:27 AM, "Andrew Grieve" <ag...@chromium.org> wrote:
>Fil, is there any way on ci.cordova.io to see which tests are failing and
>on which devices?
Yep, click the outer slice on the pie chart - this should popup the failed
assertions for a particular device.
>
>AFAIK, the slice() tests that braden added *should* be passing on both iOS
>& Android. If they are not, we should fix them.
It looks like the File constructor is failing on Android. 'null is not a
constructor'. Click the outer pie chart for specifics on specific devices.
The contact failures are "normal" (basically, the time-out tests). The
rest, though, is new.
Re: mobile spec pass rate sizable drop on android
Posted by Filip Maj <fi...@adobe.com>.
As well, the latest mobile-spec is not running at all on Android 2.x
devices. This definitely needs to be fixed.
On 1/21/13 10:27 AM, "Andrew Grieve" <ag...@chromium.org> wrote:
>Fil, is there any way on ci.cordova.io to see which tests are failing and
>on which devices?
>
>AFAIK, the slice() tests that braden added *should* be passing on both iOS
>& Android. If they are not, we should fix them.
>
>I added one test that checks that native Blob objects still work with
>FileReader. The test fails on iOS 5 since iOS5 does not support the Blob
>constructor, and they also fail on Android < 3.0 since it doesn't support
>the File API natively. We could just do a version check on Android < 3 &
>iOS < 6 to make skip the test.
>
>The relevant bug for it is here:
>https://issues.apache.org/jira/browse/CB-2167
>There are sub-bugs for BB and WP. Not sure if anyone has the intention of
>addressing this for this release? For the JS-based platforms, the
>implementation should be quite easy, in that you can just use the
>platform's Blob.slice method.
>
>
>
>On Mon, Jan 21, 2013 at 1:07 PM, Filip Maj <fi...@adobe.com> wrote:
>
>> Hey everyone,
>>
>> Working over the weekend on the ci dashboard I noticed that the pass
>>rate
>> on android for mobile-spec dropped from ~95% to ~85%. It looks like the
>> majority of failures are due to new tests for the File slice stuff that
>> was added recently, perhaps also related to the Blob stuff.
>>
>> If you head to ci.cordova.io and click on the outer pie chart pieces
>> (representing individual devices) you'll see a list of failures on
>> particular devices.
>>
>> It looks like some of this stuff is failing on iOS too (there's a Blob
>> constructor failure), but there is only one failure on iOS vs. 35+ on
>> Android.
>>
>> Additionally, this is just on two platforms. Not sure what the situation
>> is on BlackBerry, WP, and our other supported platforms, but I'm
>>assuming
>> no work was done on the new APIs for these platforms.
>>
>> Andrew/Michal/Braden you guys were working on this stuff, ya? Are we
>>going
>> to ship incomplete slice and blob implementations for 2.4.0rc1? I don't
>> care if we do, but I do care about cross-platform parity for new
>>features
>> being shipped, and I'm concerned there is no plan for that with this new
>> File API addition.
>>
>>
Re: mobile spec pass rate sizable drop on android
Posted by Andrew Grieve <ag...@chromium.org>.
Fil, is there any way on ci.cordova.io to see which tests are failing and
on which devices?
AFAIK, the slice() tests that braden added *should* be passing on both iOS
& Android. If they are not, we should fix them.
I added one test that checks that native Blob objects still work with
FileReader. The test fails on iOS 5 since iOS5 does not support the Blob
constructor, and they also fail on Android < 3.0 since it doesn't support
the File API natively. We could just do a version check on Android < 3 &
iOS < 6 to make skip the test.
The relevant bug for it is here:
https://issues.apache.org/jira/browse/CB-2167
There are sub-bugs for BB and WP. Not sure if anyone has the intention of
addressing this for this release? For the JS-based platforms, the
implementation should be quite easy, in that you can just use the
platform's Blob.slice method.
On Mon, Jan 21, 2013 at 1:07 PM, Filip Maj <fi...@adobe.com> wrote:
> Hey everyone,
>
> Working over the weekend on the ci dashboard I noticed that the pass rate
> on android for mobile-spec dropped from ~95% to ~85%. It looks like the
> majority of failures are due to new tests for the File slice stuff that
> was added recently, perhaps also related to the Blob stuff.
>
> If you head to ci.cordova.io and click on the outer pie chart pieces
> (representing individual devices) you'll see a list of failures on
> particular devices.
>
> It looks like some of this stuff is failing on iOS too (there's a Blob
> constructor failure), but there is only one failure on iOS vs. 35+ on
> Android.
>
> Additionally, this is just on two platforms. Not sure what the situation
> is on BlackBerry, WP, and our other supported platforms, but I'm assuming
> no work was done on the new APIs for these platforms.
>
> Andrew/Michal/Braden you guys were working on this stuff, ya? Are we going
> to ship incomplete slice and blob implementations for 2.4.0rc1? I don't
> care if we do, but I do care about cross-platform parity for new features
> being shipped, and I'm concerned there is no plan for that with this new
> File API addition.
>
>
Re: mobile spec pass rate sizable drop on android
Posted by Becky Gibson <gi...@gmail.com>.
I can reliably reproduce that issue but only in the manual tests. I do have a local branch to fix it - the fix is pretty straightforward. I didn't do it when I filed the issue because we keep talking abt over hauling media.
-becky
Sent from my iPad
On Jan 21, 2013, at 5:58 PM, Shazron <sh...@gmail.com> wrote:
> I tested with the cordova-js 2.4.0rc1, and all tests pass. There is one intermittent failure though, relating to Media.position, which doesn't seem a blocker to me (see attached screenshot). Might be related to: https://issues.apache.org/jira/browse/CB-1452
>
>
>
>
> On Mon, Jan 21, 2013 at 1:04 PM, Shazron <sh...@gmail.com> wrote:
>> I updated the cordova-js on iOS with cordova-js commit 1aa3643deaa9f14970806277d5f651f3cd78caa9 (the latest as of this email) and I got all the automatic tests to pass. I'll be doing more tests before I would consider a tag, probably later today.
>>
>>
>> On Mon, Jan 21, 2013 at 10:07 AM, Filip Maj <fi...@adobe.com> wrote:
>>> Hey everyone,
>>>
>>> Working over the weekend on the ci dashboard I noticed that the pass rate
>>> on android for mobile-spec dropped from ~95% to ~85%. It looks like the
>>> majority of failures are due to new tests for the File slice stuff that
>>> was added recently, perhaps also related to the Blob stuff.
>>>
>>> If you head to ci.cordova.io and click on the outer pie chart pieces
>>> (representing individual devices) you'll see a list of failures on
>>> particular devices.
>>>
>>> It looks like some of this stuff is failing on iOS too (there's a Blob
>>> constructor failure), but there is only one failure on iOS vs. 35+ on
>>> Android.
>>>
>>> Additionally, this is just on two platforms. Not sure what the situation
>>> is on BlackBerry, WP, and our other supported platforms, but I'm assuming
>>> no work was done on the new APIs for these platforms.
>>>
>>> Andrew/Michal/Braden you guys were working on this stuff, ya? Are we going
>>> to ship incomplete slice and blob implementations for 2.4.0rc1? I don't
>>> care if we do, but I do care about cross-platform parity for new features
>>> being shipped, and I'm concerned there is no plan for that with this new
>>> File API addition.
>
Re: mobile spec pass rate sizable drop on android
Posted by Shazron <sh...@gmail.com>.
I tested with the cordova-js 2.4.0rc1, and all tests pass. There is one
intermittent failure though, relating to Media.position, which doesn't seem
a blocker to me (see attached screenshot). Might be related to:
https://issues.apache.org/jira/browse/CB-1452
[image: Inline image 1]
On Mon, Jan 21, 2013 at 1:04 PM, Shazron <sh...@gmail.com> wrote:
> I updated the cordova-js on iOS with cordova-js commit
> 1aa3643deaa9f14970806277d5f651f3cd78caa9 (the latest as of this email) and
> I got all the automatic tests to pass. I'll be doing more tests before I
> would consider a tag, probably later today.
>
>
> On Mon, Jan 21, 2013 at 10:07 AM, Filip Maj <fi...@adobe.com> wrote:
>
>> Hey everyone,
>>
>> Working over the weekend on the ci dashboard I noticed that the pass rate
>> on android for mobile-spec dropped from ~95% to ~85%. It looks like the
>> majority of failures are due to new tests for the File slice stuff that
>> was added recently, perhaps also related to the Blob stuff.
>>
>> If you head to ci.cordova.io and click on the outer pie chart pieces
>> (representing individual devices) you'll see a list of failures on
>> particular devices.
>>
>> It looks like some of this stuff is failing on iOS too (there's a Blob
>> constructor failure), but there is only one failure on iOS vs. 35+ on
>> Android.
>>
>> Additionally, this is just on two platforms. Not sure what the situation
>> is on BlackBerry, WP, and our other supported platforms, but I'm assuming
>> no work was done on the new APIs for these platforms.
>>
>> Andrew/Michal/Braden you guys were working on this stuff, ya? Are we going
>> to ship incomplete slice and blob implementations for 2.4.0rc1? I don't
>> care if we do, but I do care about cross-platform parity for new features
>> being shipped, and I'm concerned there is no plan for that with this new
>> File API addition.
>>
>>
>
Re: mobile spec pass rate sizable drop on android
Posted by Shazron <sh...@gmail.com>.
I updated the cordova-js on iOS with cordova-js commit
1aa3643deaa9f14970806277d5f651f3cd78caa9 (the latest as of this email) and
I got all the automatic tests to pass. I'll be doing more tests before I
would consider a tag, probably later today.
On Mon, Jan 21, 2013 at 10:07 AM, Filip Maj <fi...@adobe.com> wrote:
> Hey everyone,
>
> Working over the weekend on the ci dashboard I noticed that the pass rate
> on android for mobile-spec dropped from ~95% to ~85%. It looks like the
> majority of failures are due to new tests for the File slice stuff that
> was added recently, perhaps also related to the Blob stuff.
>
> If you head to ci.cordova.io and click on the outer pie chart pieces
> (representing individual devices) you'll see a list of failures on
> particular devices.
>
> It looks like some of this stuff is failing on iOS too (there's a Blob
> constructor failure), but there is only one failure on iOS vs. 35+ on
> Android.
>
> Additionally, this is just on two platforms. Not sure what the situation
> is on BlackBerry, WP, and our other supported platforms, but I'm assuming
> no work was done on the new APIs for these platforms.
>
> Andrew/Michal/Braden you guys were working on this stuff, ya? Are we going
> to ship incomplete slice and blob implementations for 2.4.0rc1? I don't
> care if we do, but I do care about cross-platform parity for new features
> being shipped, and I'm concerned there is no plan for that with this new
> File API addition.
>
>