You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/04 10:36:22 UTC

[GitHub] [flink] RyanSkraba opened a new pull request, #19350: [FLINK-27046][tests][JUnit5 migration] flink-X-glue-schema-registry

RyanSkraba opened a new pull request, #19350:
URL: https://github.com/apache/flink/pull/19350

   ## What is the purpose of the change
   
   Update the `flink-formats/flink-avro-glue-schema-registry` and `flink-formats/flink-json-glue-schema-registry` module to AssertJ and JUnit 5 following the [JUnit 5 Migration Guide](https://docs.google.com/document/d/1514Wa_aNB9bJUen4xm5uiuXOooOJTtXqS_Jqk9KJitU/edit)
   
   This was an easy change: it was already based on AssertJ
   
   ## Brief change log
   
   * Removed dependences on JUnit 4, JUnit 5 Assertions and Hamcrest where possible.
   
   ## Verifying this change
   
   This change is a code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive):no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #19350: [FLINK-27046][tests][JUnit5 migration] flink-X-glue-schema-registry

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19350:
URL: https://github.com/apache/flink/pull/19350#issuecomment-1087394869

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e4c57de8e7220effb2625308df783bafa6f0b238",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "e4c57de8e7220effb2625308df783bafa6f0b238",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e4c57de8e7220effb2625308df783bafa6f0b238 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol merged pull request #19350: [FLINK-27046][tests][JUnit5 migration] flink-X-glue-schema-registry

Posted by GitBox <gi...@apache.org>.
zentol merged PR #19350:
URL: https://github.com/apache/flink/pull/19350


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org