You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "clintropolis (via GitHub)" <gi...@apache.org> on 2026/08/18 09:33:01 UTC
[PR] fix: embedded-tests start metric event collector early so logs are less noisy (druid)
clintropolis opened a new pull request, #20056:
URL: https://github.com/apache/druid/pull/20056
### Description
Noticed while running a test that the logs complained a bunch during service startup because they wanted to emit metrics but the collector was not running yet, leaving a bunch of errors like:
```
2026-08-18T09:22:53,034 WARN [HttpPostEmitter-2] org.apache.druid.java.util.common.RetryUtils - Retrying (2 of 2) in 1,221ms.
java.util.concurrent.ExecutionException: java.net.ConnectException: Connection refused: /192.168.1.80:9301
at java.base/java.util.concurrent.CompletableFuture.wrapInExecutionException(CompletableFuture.java:345)
at java.base/java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:440)
...
at org.apache.druid.java.util.emitter.core.HttpPostEmitter$EmittingThread.sendWithRetries(HttpPostEmitter.java:661)
at
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] fix: embedded-tests start metric event collector early so logs are less noisy (druid)
Posted by "FrankChen021 (via GitHub)" <gi...@apache.org>.
FrankChen021 commented on code in PR #20056:
URL: https://github.com/apache/druid/pull/20056#discussion_r3813160754
##########
embedded-tests/src/test/java/org/apache/druid/testing/embedded/docker/IngestionDockerTest.java:
##########
@@ -54,14 +54,14 @@ protected EmbeddedDruidCluster addServers(EmbeddedDruidCluster cluster)
return cluster
.useDefaultTimeoutForLatchableEmitter(240)
.useContainerFriendlyHostname()
+ .addServer(eventCollector)
Review Comment:
Thanks. K3sClusterResource.createConfigMapForCommonProperties has a separate removal using the same misspelled modulesForEmbeddedTests key. Fixing only DruidContainerResource.FORBIDDEN_PROPERTIES covers Docker paths but still leaks druid.extensions.modulesForEmbeddedTest into Kubernetes pods. Please correct both.
<!-- mergelens:review -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] fix: embedded-tests start metric event collector early so logs are less noisy (druid)
Posted by "kfaraz (via GitHub)" <gi...@apache.org>.
kfaraz commented on code in PR #20056:
URL: https://github.com/apache/druid/pull/20056#discussion_r3804048630
##########
embedded-tests/src/test/java/org/apache/druid/testing/embedded/docker/IngestionDockerTest.java:
##########
@@ -54,14 +54,14 @@ protected EmbeddedDruidCluster addServers(EmbeddedDruidCluster cluster)
return cluster
.useDefaultTimeoutForLatchableEmitter(240)
.useContainerFriendlyHostname()
+ .addServer(eventCollector)
Review Comment:
Good catch. We should fix up the `DruidContainerResource.FORBIDDEN_PROPERTIES`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] fix: embedded-tests start metric event collector early so logs are less noisy (druid)
Posted by "kfaraz (via GitHub)" <gi...@apache.org>.
kfaraz commented on code in PR #20056:
URL: https://github.com/apache/druid/pull/20056#discussion_r3827249895
##########
embedded-tests/src/test/java/org/apache/druid/testing/embedded/docker/IngestionDockerTest.java:
##########
@@ -54,14 +54,14 @@ protected EmbeddedDruidCluster addServers(EmbeddedDruidCluster cluster)
return cluster
.useDefaultTimeoutForLatchableEmitter(240)
.useContainerFriendlyHostname()
+ .addServer(eventCollector)
Review Comment:
This can be addressed in a follow up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] fix: embedded-tests start metric event collector early so logs are less noisy (druid)
Posted by "FrankChen021 (via GitHub)" <gi...@apache.org>.
FrankChen021 commented on code in PR #20056:
URL: https://github.com/apache/druid/pull/20056#discussion_r3804005137
##########
embedded-tests/src/test/java/org/apache/druid/testing/embedded/docker/IngestionDockerTest.java:
##########
@@ -54,14 +54,14 @@ protected EmbeddedDruidCluster addServers(EmbeddedDruidCluster cluster)
return cluster
.useDefaultTimeoutForLatchableEmitter(240)
.useContainerFriendlyHostname()
+ .addServer(eventCollector)
Review Comment:
[P2] Do not leak embedded-test mode into containers
This makes the event collector the first embedded server, so EmbeddedDruidCluster adds druid.extensions.modulesForEmbeddedTest before the Docker resources start. DruidContainerResource copies common properties into each container, but its exclusion list uses the misspelled plural modulesForEmbeddedTests, leaving the actual property enabled. The containers therefore run ExtensionsLoader in embedded-test filtering mode and can silently skip configured extension modules. Remove this property from external service configs using the correct key; apply the same fix to the backward-compatibility and K3s paths.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] fix: embedded-tests start metric event collector early so logs are less noisy (druid)
Posted by "kfaraz (via GitHub)" <gi...@apache.org>.
kfaraz merged PR #20056:
URL: https://github.com/apache/druid/pull/20056
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org