[GitHub] [iotdb] jt2594838 commented on a change in pull request #5113: [To rel/0.12][IOTDB-2603]Fix compaction recover

[GitBox <gi...@apache.org>]

jt2594838 commented on a change in pull request #5113:
URL: https://github.com/apache/iotdb/pull/5113#discussion_r813840365



##########
File path: server/src/main/java/org/apache/iotdb/db/engine/merge/task/RecoverMergeTask.java
##########
@@ -80,7 +95,39 @@ public void recoverMerge() throws IOException, MetadataException {
     }
   }
 
-  private void resumeAfterFilesLogged() throws IOException {
+  private void handleWhenAllSourceFilesExist() throws IOException {
     cleanUp(false);
+    tsFileManagement.removeMergingModification();
+  }
+
+  private void handleWhenSomeSourceFilesLost() throws IOException {
+    for (TsFileResource sourceSeqResource : resource.getSeqFiles()) {
+      File targetFile = modifyTsFileNameUnseqMergCnt(sourceSeqResource.getTsFile());
+      File targetFileResource = new File(targetFile.getPath() + TsFileResource.RESOURCE_SUFFIX);
+      File tmpTargetFile = new File(sourceSeqResource.getTsFilePath() + MERGE_SUFFIX);
+      // move to target file and target resource file
+      if (!targetFile.exists()) {
+        // move target file
+        FSFactoryProducer.getFSFactory().moveFile(tmpTargetFile, targetFile);
+      }
+      // serialize target resource file
+      TsFileResource targetTsFileResouce = new TsFileResource(targetFile);
+      try (TsFileSequenceReader reader = new TsFileSequenceReader(targetFile.getAbsolutePath())) {
+        FileLoaderUtils.updateTsFileResource(reader, targetTsFileResouce);
+      }
+      targetTsFileResouce.serialize();

Review comment:
       Is this newly generated resource managed by TsFileManagement?

##########
File path: server/src/main/java/org/apache/iotdb/db/engine/merge/task/RecoverMergeTask.java
##########
@@ -80,7 +95,39 @@ public void recoverMerge() throws IOException, MetadataException {
     }
   }
 
-  private void resumeAfterFilesLogged() throws IOException {
+  private void handleWhenAllSourceFilesExist() throws IOException {
     cleanUp(false);
+    tsFileManagement.removeMergingModification();
+  }
+
+  private void handleWhenSomeSourceFilesLost() throws IOException {
+    for (TsFileResource sourceSeqResource : resource.getSeqFiles()) {
+      File targetFile = modifyTsFileNameUnseqMergCnt(sourceSeqResource.getTsFile());
+      File targetFileResource = new File(targetFile.getPath() + TsFileResource.RESOURCE_SUFFIX);
+      File tmpTargetFile = new File(sourceSeqResource.getTsFilePath() + MERGE_SUFFIX);
+      // move to target file and target resource file
+      if (!targetFile.exists()) {
+        // move target file
+        FSFactoryProducer.getFSFactory().moveFile(tmpTargetFile, targetFile);
+      }
+      // serialize target resource file
+      TsFileResource targetTsFileResouce = new TsFileResource(targetFile);
+      try (TsFileSequenceReader reader = new TsFileSequenceReader(targetFile.getAbsolutePath())) {
+        FileLoaderUtils.updateTsFileResource(reader, targetTsFileResouce);
+      }
+      targetTsFileResouce.serialize();
+
+      // delete source seq file
+      sourceSeqResource.remove();
+
+      // delete merge file
+      File mergeFile = new File(sourceSeqResource.getTsFilePath() + MERGE_SUFFIX);
+      if (mergeFile.exists()) {
+        mergeFile.delete();
+      }
+
+      sourceSeqResource.setFile(targetFile);

Review comment:
       What is the point of `sourceSeqResource.setFile(targetFile);`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org