You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/02/12 18:16:26 UTC

[GitHub] [kafka] rhauch opened a new pull request #10122: KAFKA-12326: Corrected regresion in MirrorMaker 2 executable introduced with KAFKA-10021

rhauch opened a new pull request #10122:
URL: https://github.com/apache/kafka/pull/10122


   Fixes the recent change (#9780) to the `MirrorMaker` class (used only in the MirrorMaker 2 executable) that uses a `SharedTopicAdmin` client as part of Connect, so that the class passes the distributed worker properties rather than the MM2 properties into the `SharedTopicAdmin`.
   
   The error running the MirrorMaker 2 executable was reproduced manually without this fix, and then this one-line change was manually verified to correct the problem. Unfortunately, the `MirrorMaker` class as currently written is not easily tested, so this change only includes the fix to unblock the 2.6.2 release and relies upon the aforementioned manual testing for verification.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] dajac commented on pull request #10122: KAFKA-12326: Corrected regresion in MirrorMaker 2 executable introduced with KAFKA-10021

Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #10122:
URL: https://github.com/apache/kafka/pull/10122#issuecomment-778592209


   @rhauch Should we backport it to 2.8 branch as well?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] rhauch commented on pull request #10122: KAFKA-12326: Corrected regresion in MirrorMaker 2 executable introduced with KAFKA-10021

Posted by GitBox <gi...@apache.org>.
rhauch commented on pull request #10122:
URL: https://github.com/apache/kafka/pull/10122#issuecomment-778717408


   @dajac thanks for the prompt. Yes, I've backported this to the `2.8` branch.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] rhauch merged pull request #10122: KAFKA-12326: Corrected regresion in MirrorMaker 2 executable introduced with KAFKA-10021

Posted by GitBox <gi...@apache.org>.
rhauch merged pull request #10122:
URL: https://github.com/apache/kafka/pull/10122


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] rhauch commented on pull request #10122: KAFKA-12326: Corrected regresion in MirrorMaker 2 executable introduced with KAFKA-10021

Posted by GitBox <gi...@apache.org>.
rhauch commented on pull request #10122:
URL: https://github.com/apache/kafka/pull/10122#issuecomment-778499358


   Build passed on JDK 8 & 11, unrelated test failures on JDK 15.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org