[PR] drivers/mmcsd: Rename mmcsd_read_csd to mmcsd_read_extcsd [nuttx]

["gneworld (via GitHub)" <gi...@apache.org>]

gneworld opened a new pull request, #13710:
URL: https://github.com/apache/nuttx/pull/13710

   
   
   ## Summary
    Rename mmcsd_read_csd to mmcsd_read_extcsd,  since it really read extcsd register not csd register and remove the temp buffer inside it.
   ## Impact
    mmcsd
   ## Testing
    cortex m55
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] drivers/mmcsd: Rename mmcsd_read_csd to mmcsd_read_extcsd [nuttx]

["nuttxpr (via GitHub)" <gi...@apache.org>]

nuttxpr commented on PR #13710:
URL: https://github.com/apache/nuttx/pull/13710#issuecomment-2381078080

   [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
   
   
   
   **No, this PR does not fully meet the NuttX requirements.**
   
   **Missing Information:**
   
   * **Summary:**
       * **Why** is this change necessary? What is the problem with the current naming and buffer usage?
       * **How** does removing the temporary buffer work? What are the implications for memory usage and performance? 
   * **Impact:**
       * Be specific about which architectures, boards, or drivers are affected. 
       * **Impact on user:** Will any user-facing APIs change?
       * **Impact on compatibility:**  Are there any backward compatibility concerns?
   * **Testing:**
       * Provide more details about your build host and target environments:
           * OS versions
           * Compiler versions
           * Specific ARM board model 
       * **Testing logs:**  The provided logs are placeholders. Please include actual logs showing the behavior before and after the change.
   
   **Recommendations:**
   
   * Expand the "Summary" section to clearly articulate the problem, solution, and rationale behind the changes.
   * Provide specific details in the "Impact" section, addressing all points with concrete information.
   * Replace placeholder testing logs with real output from your testing environment. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org