[GitHub] [maven-shade-plugin] rfscholte commented on a change in pull request #90: [MSHADE-382] - Add property to skip execution

[GitBox <gi...@apache.org>]

rfscholte commented on a change in pull request #90:
URL: https://github.com/apache/maven-shade-plugin/pull/90#discussion_r633064165



##########
File path: src/test/java/org/apache/maven/plugins/shade/mojo/ShadeMojoTest.java
##########
@@ -62,6 +62,43 @@
 public class ShadeMojoTest
     extends PlexusTestCase
 {
+    public void testSkipShading() throws Exception
+    {
+        final ShadeMojo mojo = new ShadeMojo();

Review comment:
       This is not a not a PlexusTest, but a unittest using reflection. And I understand it follows other test examples, but this keeps increasing the technical dept.
   I suggest to drop this as the non-default value is already covered by the integration test, the default value with all the other tests.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org