You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/09/22 12:46:20 UTC

[GitHub] [skywalking-java] wu-sheng removed a comment on pull request #34: Fix spring mvc plugin

wu-sheng removed a comment on pull request #34:
URL: https://github.com/apache/skywalking-java/pull/34#issuecomment-924891557


   I would recommend you to upgrade this interceptor to v2 API. Take a look at this, https://skywalking.apache.org/docs/skywalking-java/latest/en/setup/service-agent/java-agent/java-plugin-development-guide/#v2-apis-1
   
   Once span created, you could use `MethodInvocationContext` to propagate for the `afterMethod`. Then you don't need to check depth anymore, which is actually not being used by any plugin.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org