You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/06/24 12:26:23 UTC

[GitHub] [pulsar] freeznet commented on a change in pull request #11029: [WIP][C++][Python] Add connection timeout configuration

freeznet commented on a change in pull request #11029:
URL: https://github.com/apache/pulsar/pull/11029#discussion_r657898391



##########
File path: pulsar-client-cpp/python/pulsar/__init__.py
##########
@@ -355,6 +355,7 @@ class Client:
     def __init__(self, service_url,
                  authentication=None,
                  operation_timeout_seconds=30,
+                 connection_timeout_ms=10000,

Review comment:
       please add the new parameter to the end of the parameters list, otherwise it will breaks the python runtime since it creates `Client` with positioned parameter but not by keyword parameter.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org