[GitHub] [hbase] tedyu commented on a change in pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…

[GitBox <gi...@apache.org>]

tedyu commented on a change in pull request #2202:
URL: https://github.com/apache/hbase/pull/2202#discussion_r466812559



##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java
##########
@@ -1312,6 +1312,14 @@ default boolean abortProcedure(long procId, boolean mayInterruptIfRunning) throw
    */
   void rollWALWriter(ServerName serverName) throws IOException, FailedLogCloseException;
 
+  /**
+   * Archive the earliest log file.
+   *
+   * @param serverName The servername of the regionserver.
+   * @throws IOException if a remote or network exception occurs
+   */
+  void archiveWAL(ServerName serverName) throws IOException;

Review comment:
       Should method name reflect that the earliest log is archived ?

##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/RequestConverter.java
##########
@@ -883,6 +884,20 @@ public static RollWALWriterRequest buildRollWALWriterRequest() {
     return ROLL_WAL_WRITER_REQUEST;
   }
 
+  /**
+   * @see #buildArchiveWALRequest()
+   */
+  private static ArchiveWALRequest ARCHIVE_WAL_REQUEST = ArchiveWALRequest.newBuilder()
+    .build();
+
+  /**
+   * Create a new ArchiveWALRequest

Review comment:
       No new request is created.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org