You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Daniel Gómez Ferro (Created JIRA)" <ji...@apache.org> on 2011/11/30 15:47:40 UTC
[jira] [Created] (HBASE-4903) Return a result from
RegionObserver.preIncrement()
Return a result from RegionObserver.preIncrement()
--------------------------------------------------
Key: HBASE-4903
URL: https://issues.apache.org/jira/browse/HBASE-4903
Project: HBase
Issue Type: Improvement
Reporter: Daniel Gómez Ferro
The only way to return a result from RegionObserver.preIncrement() is to use Result.readFields() after serializing the correct result.
This can be fixed either returning a Result object from that function or adding setters to Result. Another option is to modify the parameters and receive a List<KeyValue> as preGet() does.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4903) Return a result from
RegionObserver.preIncrement()
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13161418#comment-13161418 ]
Hudson commented on HBASE-4903:
-------------------------------
Integrated in HBase-TRUNK-security #18 (See [https://builds.apache.org/job/HBase-TRUNK-security/18/])
HBASE-4903 Return a result from RegionObserver.preIncrement (Daniel Gómez Ferro)
larsh :
Files :
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/SimpleRegionObserver.java
> Return a result from RegionObserver.preIncrement()
> --------------------------------------------------
>
> Key: HBASE-4903
> URL: https://issues.apache.org/jira/browse/HBASE-4903
> Project: HBase
> Issue Type: Improvement
> Reporter: Daniel Gómez Ferro
> Fix For: 0.94.0, 0.92.1
>
> Attachments: HBASE-4903-0.92.patch, HBASE-4903.patch, HBASE-4903.patch
>
>
> The only way to return a result from RegionObserver.preIncrement() is to use Result.readFields() after serializing the correct result.
> This can be fixed either returning a Result object from that function or adding setters to Result. Another option is to modify the parameters and receive a List<KeyValue> as preGet() does.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4903) Return a result from
RegionObserver.preIncrement()
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13161416#comment-13161416 ]
Hudson commented on HBASE-4903:
-------------------------------
Integrated in HBase-0.92-security #28 (See [https://builds.apache.org/job/HBase-0.92-security/28/])
HBASE-4903 Return a result from RegionObserver.preIncrement (Daniel Gómez Ferro)
larsh :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/coprocessor/SimpleRegionObserver.java
> Return a result from RegionObserver.preIncrement()
> --------------------------------------------------
>
> Key: HBASE-4903
> URL: https://issues.apache.org/jira/browse/HBASE-4903
> Project: HBase
> Issue Type: Improvement
> Reporter: Daniel Gómez Ferro
> Fix For: 0.94.0, 0.92.1
>
> Attachments: HBASE-4903-0.92.patch, HBASE-4903.patch, HBASE-4903.patch
>
>
> The only way to return a result from RegionObserver.preIncrement() is to use Result.readFields() after serializing the correct result.
> This can be fixed either returning a Result object from that function or adding setters to Result. Another option is to modify the parameters and receive a List<KeyValue> as preGet() does.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4903) Return a result from
RegionObserver.preIncrement()
Posted by "Lars Hofhansl (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160319#comment-13160319 ]
Lars Hofhansl commented on HBASE-4903:
--------------------------------------
Thanks for fixing append as well. Patch looks good... +1
The two failures look unrelated, I'll double check before I commit.
> Return a result from RegionObserver.preIncrement()
> --------------------------------------------------
>
> Key: HBASE-4903
> URL: https://issues.apache.org/jira/browse/HBASE-4903
> Project: HBase
> Issue Type: Improvement
> Reporter: Daniel Gómez Ferro
> Attachments: HBASE-4903.patch, HBASE-4903.patch
>
>
> The only way to return a result from RegionObserver.preIncrement() is to use Result.readFields() after serializing the correct result.
> This can be fixed either returning a Result object from that function or adding setters to Result. Another option is to modify the parameters and receive a List<KeyValue> as preGet() does.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4903) Return a result from
RegionObserver.preIncrement()
Posted by "Lars Hofhansl (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160537#comment-13160537 ]
Lars Hofhansl commented on HBASE-4903:
--------------------------------------
Cool. Will do this evening.
> Return a result from RegionObserver.preIncrement()
> --------------------------------------------------
>
> Key: HBASE-4903
> URL: https://issues.apache.org/jira/browse/HBASE-4903
> Project: HBase
> Issue Type: Improvement
> Reporter: Daniel Gómez Ferro
> Attachments: HBASE-4903.patch, HBASE-4903.patch
>
>
> The only way to return a result from RegionObserver.preIncrement() is to use Result.readFields() after serializing the correct result.
> This can be fixed either returning a Result object from that function or adding setters to Result. Another option is to modify the parameters and receive a List<KeyValue> as preGet() does.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4903) Return a result from
RegionObserver.preIncrement()
Posted by "Lars Hofhansl (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160179#comment-13160179 ]
Lars Hofhansl commented on HBASE-4903:
--------------------------------------
{pre|post}Append has the same problem.
> Return a result from RegionObserver.preIncrement()
> --------------------------------------------------
>
> Key: HBASE-4903
> URL: https://issues.apache.org/jira/browse/HBASE-4903
> Project: HBase
> Issue Type: Improvement
> Reporter: Daniel Gómez Ferro
> Attachments: HBASE-4903.patch
>
>
> The only way to return a result from RegionObserver.preIncrement() is to use Result.readFields() after serializing the correct result.
> This can be fixed either returning a Result object from that function or adding setters to Result. Another option is to modify the parameters and receive a List<KeyValue> as preGet() does.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4903) Return a result from
RegionObserver.preIncrement()
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162060#comment-13162060 ]
Hudson commented on HBASE-4903:
-------------------------------
Integrated in HBase-0.92-security #29 (See [https://builds.apache.org/job/HBase-0.92-security/29/])
HBASE-4903 addendum for security build
larsh :
Files :
* /hbase/branches/0.92/security/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java
> Return a result from RegionObserver.preIncrement()
> --------------------------------------------------
>
> Key: HBASE-4903
> URL: https://issues.apache.org/jira/browse/HBASE-4903
> Project: HBase
> Issue Type: Improvement
> Reporter: Daniel Gómez Ferro
> Fix For: 0.94.0, 0.92.1
>
> Attachments: 4903-add.txt, HBASE-4903-0.92.patch, HBASE-4903.patch, HBASE-4903.patch
>
>
> The only way to return a result from RegionObserver.preIncrement() is to use Result.readFields() after serializing the correct result.
> This can be fixed either returning a Result object from that function or adding setters to Result. Another option is to modify the parameters and receive a List<KeyValue> as preGet() does.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4903) Return a result from
RegionObserver.preIncrement()
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160429#comment-13160429 ]
stack commented on HBASE-4903:
------------------------------
+1 on patch. I moved all outstanding 0.92.0 issues to 0.92.1. This one, commit to 0.92 branch and mark fix as 0.92.1. If (smile) a new RC, I'll do fix up so version is 0.92.0 so this fix is included in 0.92.0. I think thats the right thing to do.
> Return a result from RegionObserver.preIncrement()
> --------------------------------------------------
>
> Key: HBASE-4903
> URL: https://issues.apache.org/jira/browse/HBASE-4903
> Project: HBase
> Issue Type: Improvement
> Reporter: Daniel Gómez Ferro
> Attachments: HBASE-4903.patch, HBASE-4903.patch
>
>
> The only way to return a result from RegionObserver.preIncrement() is to use Result.readFields() after serializing the correct result.
> This can be fixed either returning a Result object from that function or adding setters to Result. Another option is to modify the parameters and receive a List<KeyValue> as preGet() does.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4903) Return a result from
RegionObserver.preIncrement()
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13161515#comment-13161515 ]
Hudson commented on HBASE-4903:
-------------------------------
Integrated in HBase-TRUNK #2508 (See [https://builds.apache.org/job/HBase-TRUNK/2508/])
HBASE-4903 addendum for security build
larsh :
Files :
* /hbase/trunk/security/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java
> Return a result from RegionObserver.preIncrement()
> --------------------------------------------------
>
> Key: HBASE-4903
> URL: https://issues.apache.org/jira/browse/HBASE-4903
> Project: HBase
> Issue Type: Improvement
> Reporter: Daniel Gómez Ferro
> Fix For: 0.94.0, 0.92.1
>
> Attachments: 4903-add.txt, HBASE-4903-0.92.patch, HBASE-4903.patch, HBASE-4903.patch
>
>
> The only way to return a result from RegionObserver.preIncrement() is to use Result.readFields() after serializing the correct result.
> This can be fixed either returning a Result object from that function or adding setters to Result. Another option is to modify the parameters and receive a List<KeyValue> as preGet() does.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4903) Return a result from
RegionObserver.preIncrement()
Posted by "Lars Hofhansl (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160414#comment-13160414 ]
Lars Hofhansl commented on HBASE-4903:
--------------------------------------
Hmm... Good point. I think so.
If you +1 it, I'll put it into 0.92 and trunk :)
(0.92 target is now 0.92.1?)
> Return a result from RegionObserver.preIncrement()
> --------------------------------------------------
>
> Key: HBASE-4903
> URL: https://issues.apache.org/jira/browse/HBASE-4903
> Project: HBase
> Issue Type: Improvement
> Reporter: Daniel Gómez Ferro
> Attachments: HBASE-4903.patch, HBASE-4903.patch
>
>
> The only way to return a result from RegionObserver.preIncrement() is to use Result.readFields() after serializing the correct result.
> This can be fixed either returning a Result object from that function or adding setters to Result. Another option is to modify the parameters and receive a List<KeyValue> as preGet() does.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4903) Return a result from
RegionObserver.preIncrement()
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-4903:
-------------------------
Fix Version/s: (was: 0.92.1)
(was: 0.94.0)
0.92.0
This will be in 0.92 afterall; cutting a new RC.
> Return a result from RegionObserver.preIncrement()
> --------------------------------------------------
>
> Key: HBASE-4903
> URL: https://issues.apache.org/jira/browse/HBASE-4903
> Project: HBase
> Issue Type: Improvement
> Reporter: Daniel Gómez Ferro
> Fix For: 0.92.0
>
> Attachments: 4903-add.txt, HBASE-4903-0.92.patch, HBASE-4903.patch, HBASE-4903.patch
>
>
> The only way to return a result from RegionObserver.preIncrement() is to use Result.readFields() after serializing the correct result.
> This can be fixed either returning a Result object from that function or adding setters to Result. Another option is to modify the parameters and receive a List<KeyValue> as preGet() does.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4903) Return a result from
RegionObserver.preIncrement()
Posted by "Daniel Gómez Ferro (Updated JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Gómez Ferro updated HBASE-4903:
--------------------------------------
Status: Patch Available (was: Open)
> Return a result from RegionObserver.preIncrement()
> --------------------------------------------------
>
> Key: HBASE-4903
> URL: https://issues.apache.org/jira/browse/HBASE-4903
> Project: HBase
> Issue Type: Improvement
> Reporter: Daniel Gómez Ferro
> Attachments: HBASE-4903.patch
>
>
> The only way to return a result from RegionObserver.preIncrement() is to use Result.readFields() after serializing the correct result.
> This can be fixed either returning a Result object from that function or adding setters to Result. Another option is to modify the parameters and receive a List<KeyValue> as preGet() does.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4903) Return a result from
RegionObserver.preIncrement()
Posted by "Lars Hofhansl (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-4903:
---------------------------------
Attachment: 4903-add.txt
Addendum for the security build (both 0.92 and trunk).
> Return a result from RegionObserver.preIncrement()
> --------------------------------------------------
>
> Key: HBASE-4903
> URL: https://issues.apache.org/jira/browse/HBASE-4903
> Project: HBase
> Issue Type: Improvement
> Reporter: Daniel Gómez Ferro
> Fix For: 0.94.0, 0.92.1
>
> Attachments: 4903-add.txt, HBASE-4903-0.92.patch, HBASE-4903.patch, HBASE-4903.patch
>
>
> The only way to return a result from RegionObserver.preIncrement() is to use Result.readFields() after serializing the correct result.
> This can be fixed either returning a Result object from that function or adding setters to Result. Another option is to modify the parameters and receive a List<KeyValue> as preGet() does.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4903) Return a result from
RegionObserver.preIncrement()
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160404#comment-13160404 ]
stack commented on HBASE-4903:
------------------------------
Should this go into 0.92? Seems like problem w/ the api?
> Return a result from RegionObserver.preIncrement()
> --------------------------------------------------
>
> Key: HBASE-4903
> URL: https://issues.apache.org/jira/browse/HBASE-4903
> Project: HBase
> Issue Type: Improvement
> Reporter: Daniel Gómez Ferro
> Attachments: HBASE-4903.patch, HBASE-4903.patch
>
>
> The only way to return a result from RegionObserver.preIncrement() is to use Result.readFields() after serializing the correct result.
> This can be fixed either returning a Result object from that function or adding setters to Result. Another option is to modify the parameters and receive a List<KeyValue> as preGet() does.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4903) Return a result from
RegionObserver.preIncrement()
Posted by "Lars Hofhansl (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160654#comment-13160654 ]
Lars Hofhansl commented on HBASE-4903:
--------------------------------------
Thanks for the patch Daniel!
> Return a result from RegionObserver.preIncrement()
> --------------------------------------------------
>
> Key: HBASE-4903
> URL: https://issues.apache.org/jira/browse/HBASE-4903
> Project: HBase
> Issue Type: Improvement
> Reporter: Daniel Gómez Ferro
> Fix For: 0.94.0, 0.92.1
>
> Attachments: HBASE-4903-0.92.patch, HBASE-4903.patch, HBASE-4903.patch
>
>
> The only way to return a result from RegionObserver.preIncrement() is to use Result.readFields() after serializing the correct result.
> This can be fixed either returning a Result object from that function or adding setters to Result. Another option is to modify the parameters and receive a List<KeyValue> as preGet() does.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4903) Return a result from
RegionObserver.preIncrement()
Posted by "Lars Hofhansl (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-4903:
---------------------------------
Attachment: HBASE-4903-0.92.patch
0.92 does not have appends, here's the 0.92 version I created and committed
> Return a result from RegionObserver.preIncrement()
> --------------------------------------------------
>
> Key: HBASE-4903
> URL: https://issues.apache.org/jira/browse/HBASE-4903
> Project: HBase
> Issue Type: Improvement
> Reporter: Daniel Gómez Ferro
> Fix For: 0.94.0, 0.92.1
>
> Attachments: HBASE-4903-0.92.patch, HBASE-4903.patch, HBASE-4903.patch
>
>
> The only way to return a result from RegionObserver.preIncrement() is to use Result.readFields() after serializing the correct result.
> This can be fixed either returning a Result object from that function or adding setters to Result. Another option is to modify the parameters and receive a List<KeyValue> as preGet() does.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4903) Return a result from
RegionObserver.preIncrement()
Posted by "Lars Hofhansl (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160655#comment-13160655 ]
Lars Hofhansl commented on HBASE-4903:
--------------------------------------
btw. I did verify that both TestReplication and TestAdmin pass locally before I committed.
> Return a result from RegionObserver.preIncrement()
> --------------------------------------------------
>
> Key: HBASE-4903
> URL: https://issues.apache.org/jira/browse/HBASE-4903
> Project: HBase
> Issue Type: Improvement
> Reporter: Daniel Gómez Ferro
> Fix For: 0.94.0, 0.92.1
>
> Attachments: HBASE-4903-0.92.patch, HBASE-4903.patch, HBASE-4903.patch
>
>
> The only way to return a result from RegionObserver.preIncrement() is to use Result.readFields() after serializing the correct result.
> This can be fixed either returning a Result object from that function or adding setters to Result. Another option is to modify the parameters and receive a List<KeyValue> as preGet() does.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4903) Return a result from
RegionObserver.preIncrement()
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160759#comment-13160759 ]
Hudson commented on HBASE-4903:
-------------------------------
Integrated in HBase-TRUNK #2505 (See [https://builds.apache.org/job/HBase-TRUNK/2505/])
HBASE-4903 Return a result from RegionObserver.preIncrement (Daniel Gómez Ferro)
larsh :
Files :
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/SimpleRegionObserver.java
> Return a result from RegionObserver.preIncrement()
> --------------------------------------------------
>
> Key: HBASE-4903
> URL: https://issues.apache.org/jira/browse/HBASE-4903
> Project: HBase
> Issue Type: Improvement
> Reporter: Daniel Gómez Ferro
> Fix For: 0.94.0, 0.92.1
>
> Attachments: HBASE-4903-0.92.patch, HBASE-4903.patch, HBASE-4903.patch
>
>
> The only way to return a result from RegionObserver.preIncrement() is to use Result.readFields() after serializing the correct result.
> This can be fixed either returning a Result object from that function or adding setters to Result. Another option is to modify the parameters and receive a List<KeyValue> as preGet() does.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4903) Return a result from
RegionObserver.preIncrement()
Posted by "Lars Hofhansl (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13161433#comment-13161433 ]
Lars Hofhansl commented on HBASE-4903:
--------------------------------------
addendum committed to 0.92 and trunk.
> Return a result from RegionObserver.preIncrement()
> --------------------------------------------------
>
> Key: HBASE-4903
> URL: https://issues.apache.org/jira/browse/HBASE-4903
> Project: HBase
> Issue Type: Improvement
> Reporter: Daniel Gómez Ferro
> Fix For: 0.94.0, 0.92.1
>
> Attachments: 4903-add.txt, HBASE-4903-0.92.patch, HBASE-4903.patch, HBASE-4903.patch
>
>
> The only way to return a result from RegionObserver.preIncrement() is to use Result.readFields() after serializing the correct result.
> This can be fixed either returning a Result object from that function or adding setters to Result. Another option is to modify the parameters and receive a List<KeyValue> as preGet() does.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4903) Return a result from
RegionObserver.preIncrement()
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160219#comment-13160219 ]
Hadoop QA commented on HBASE-4903:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12505635/HBASE-4903.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated -162 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 67 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.master.TestRollingRestart
org.apache.hadoop.hbase.master.TestRestartCluster
org.apache.hadoop.hbase.master.TestDistributedLogSplitting
org.apache.hadoop.hbase.master.TestHMasterRPCException
org.apache.hadoop.hbase.mapreduce.TestTimeRangeMapRed
org.apache.hadoop.hbase.master.TestMaster
org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFilesSplitRecovery
org.apache.hadoop.hbase.master.TestMasterRestartAfterDisablingTable
org.apache.hadoop.hbase.mapreduce.TestTableInputFormatScan
org.apache.hadoop.hbase.master.TestZKBasedOpenCloseRegion
org.apache.hadoop.hbase.TestFullLogReconstruction
org.apache.hadoop.hbase.avro.TestAvroServer
org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFiles
org.apache.hadoop.hbase.master.TestMasterFailover
org.apache.hadoop.hbase.mapreduce.TestImportTsv
org.apache.hadoop.hbase.master.TestMasterTransitions
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
org.apache.hadoop.hbase.mapreduce.TestTableMapReduce
org.apache.hadoop.hbase.master.TestOpenedRegionHandler
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/408//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/408//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/408//console
This message is automatically generated.
> Return a result from RegionObserver.preIncrement()
> --------------------------------------------------
>
> Key: HBASE-4903
> URL: https://issues.apache.org/jira/browse/HBASE-4903
> Project: HBase
> Issue Type: Improvement
> Reporter: Daniel Gómez Ferro
> Attachments: HBASE-4903.patch, HBASE-4903.patch
>
>
> The only way to return a result from RegionObserver.preIncrement() is to use Result.readFields() after serializing the correct result.
> This can be fixed either returning a Result object from that function or adding setters to Result. Another option is to modify the parameters and receive a List<KeyValue> as preGet() does.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4903) Return a result from
RegionObserver.preIncrement()
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162083#comment-13162083 ]
Hudson commented on HBASE-4903:
-------------------------------
Integrated in HBase-TRUNK-security #19 (See [https://builds.apache.org/job/HBase-TRUNK-security/19/])
HBASE-4903 addendum for security build
larsh :
Files :
* /hbase/trunk/security/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java
> Return a result from RegionObserver.preIncrement()
> --------------------------------------------------
>
> Key: HBASE-4903
> URL: https://issues.apache.org/jira/browse/HBASE-4903
> Project: HBase
> Issue Type: Improvement
> Reporter: Daniel Gómez Ferro
> Fix For: 0.94.0, 0.92.1
>
> Attachments: 4903-add.txt, HBASE-4903-0.92.patch, HBASE-4903.patch, HBASE-4903.patch
>
>
> The only way to return a result from RegionObserver.preIncrement() is to use Result.readFields() after serializing the correct result.
> This can be fixed either returning a Result object from that function or adding setters to Result. Another option is to modify the parameters and receive a List<KeyValue> as preGet() does.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4903) Return a result from
RegionObserver.preIncrement()
Posted by "Daniel Gómez Ferro (Updated JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Gómez Ferro updated HBASE-4903:
--------------------------------------
Attachment: HBASE-4903.patch
Return a Result object from RegionObserver.pre/postIncrement()
The user can easily create a new Result or forward it unmodified.
> Return a result from RegionObserver.preIncrement()
> --------------------------------------------------
>
> Key: HBASE-4903
> URL: https://issues.apache.org/jira/browse/HBASE-4903
> Project: HBase
> Issue Type: Improvement
> Reporter: Daniel Gómez Ferro
> Attachments: HBASE-4903.patch
>
>
> The only way to return a result from RegionObserver.preIncrement() is to use Result.readFields() after serializing the correct result.
> This can be fixed either returning a Result object from that function or adding setters to Result. Another option is to modify the parameters and receive a List<KeyValue> as preGet() does.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4903) Return a result from
RegionObserver.preIncrement()
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160807#comment-13160807 ]
Hudson commented on HBASE-4903:
-------------------------------
Integrated in HBase-0.92 #166 (See [https://builds.apache.org/job/HBase-0.92/166/])
HBASE-4903 Return a result from RegionObserver.preIncrement (Daniel Gómez Ferro)
larsh :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/coprocessor/SimpleRegionObserver.java
> Return a result from RegionObserver.preIncrement()
> --------------------------------------------------
>
> Key: HBASE-4903
> URL: https://issues.apache.org/jira/browse/HBASE-4903
> Project: HBase
> Issue Type: Improvement
> Reporter: Daniel Gómez Ferro
> Fix For: 0.94.0, 0.92.1
>
> Attachments: HBASE-4903-0.92.patch, HBASE-4903.patch, HBASE-4903.patch
>
>
> The only way to return a result from RegionObserver.preIncrement() is to use Result.readFields() after serializing the correct result.
> This can be fixed either returning a Result object from that function or adding setters to Result. Another option is to modify the parameters and receive a List<KeyValue> as preGet() does.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4903) Return a result from
RegionObserver.preIncrement()
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13161474#comment-13161474 ]
Hudson commented on HBASE-4903:
-------------------------------
Integrated in HBase-0.92 #168 (See [https://builds.apache.org/job/HBase-0.92/168/])
HBASE-4903 addendum for security build
larsh :
Files :
* /hbase/branches/0.92/security/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java
> Return a result from RegionObserver.preIncrement()
> --------------------------------------------------
>
> Key: HBASE-4903
> URL: https://issues.apache.org/jira/browse/HBASE-4903
> Project: HBase
> Issue Type: Improvement
> Reporter: Daniel Gómez Ferro
> Fix For: 0.94.0, 0.92.1
>
> Attachments: 4903-add.txt, HBASE-4903-0.92.patch, HBASE-4903.patch, HBASE-4903.patch
>
>
> The only way to return a result from RegionObserver.preIncrement() is to use Result.readFields() after serializing the correct result.
> This can be fixed either returning a Result object from that function or adding setters to Result. Another option is to modify the parameters and receive a List<KeyValue> as preGet() does.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4903) Return a result from
RegionObserver.preIncrement()
Posted by "Daniel Gómez Ferro (Updated JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Gómez Ferro updated HBASE-4903:
--------------------------------------
Attachment: HBASE-4903.patch
Modified pre/postAppend as well, good catch.
I removed the Result parameter from both pre* functions and updated the documentation.
> Return a result from RegionObserver.preIncrement()
> --------------------------------------------------
>
> Key: HBASE-4903
> URL: https://issues.apache.org/jira/browse/HBASE-4903
> Project: HBase
> Issue Type: Improvement
> Reporter: Daniel Gómez Ferro
> Attachments: HBASE-4903.patch, HBASE-4903.patch
>
>
> The only way to return a result from RegionObserver.preIncrement() is to use Result.readFields() after serializing the correct result.
> This can be fixed either returning a Result object from that function or adding setters to Result. Another option is to modify the parameters and receive a List<KeyValue> as preGet() does.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4903) Return a result from
RegionObserver.preIncrement()
Posted by "Lars Hofhansl (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-4903:
---------------------------------
Status: Open (was: Patch Available)
> Return a result from RegionObserver.preIncrement()
> --------------------------------------------------
>
> Key: HBASE-4903
> URL: https://issues.apache.org/jira/browse/HBASE-4903
> Project: HBase
> Issue Type: Improvement
> Reporter: Daniel Gómez Ferro
> Attachments: HBASE-4903.patch, HBASE-4903.patch
>
>
> The only way to return a result from RegionObserver.preIncrement() is to use Result.readFields() after serializing the correct result.
> This can be fixed either returning a Result object from that function or adding setters to Result. Another option is to modify the parameters and receive a List<KeyValue> as preGet() does.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4903) Return a result from
RegionObserver.preIncrement()
Posted by "Lars Hofhansl (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160183#comment-13160183 ]
Lars Hofhansl commented on HBASE-4903:
--------------------------------------
patch lgtm
> Return a result from RegionObserver.preIncrement()
> --------------------------------------------------
>
> Key: HBASE-4903
> URL: https://issues.apache.org/jira/browse/HBASE-4903
> Project: HBase
> Issue Type: Improvement
> Reporter: Daniel Gómez Ferro
> Attachments: HBASE-4903.patch
>
>
> The only way to return a result from RegionObserver.preIncrement() is to use Result.readFields() after serializing the correct result.
> This can be fixed either returning a Result object from that function or adding setters to Result. Another option is to modify the parameters and receive a List<KeyValue> as preGet() does.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-4903) Return a result from
RegionObserver.preIncrement()
Posted by "Lars Hofhansl (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl resolved HBASE-4903.
----------------------------------
Resolution: Fixed
Fix Version/s: 0.92.1
0.94.0
Hadoop Flags: Reviewed
Committed to 0.92 and trunk.
> Return a result from RegionObserver.preIncrement()
> --------------------------------------------------
>
> Key: HBASE-4903
> URL: https://issues.apache.org/jira/browse/HBASE-4903
> Project: HBase
> Issue Type: Improvement
> Reporter: Daniel Gómez Ferro
> Fix For: 0.94.0, 0.92.1
>
> Attachments: HBASE-4903-0.92.patch, HBASE-4903.patch, HBASE-4903.patch
>
>
> The only way to return a result from RegionObserver.preIncrement() is to use Result.readFields() after serializing the correct result.
> This can be fixed either returning a Result object from that function or adding setters to Result. Another option is to modify the parameters and receive a List<KeyValue> as preGet() does.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4903) Return a result from
RegionObserver.preIncrement()
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160294#comment-13160294 ]
Hadoop QA commented on HBASE-4903:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12505641/HBASE-4903.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated -162 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 67 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.replication.TestReplication
org.apache.hadoop.hbase.client.TestAdmin
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/409//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/409//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/409//console
This message is automatically generated.
> Return a result from RegionObserver.preIncrement()
> --------------------------------------------------
>
> Key: HBASE-4903
> URL: https://issues.apache.org/jira/browse/HBASE-4903
> Project: HBase
> Issue Type: Improvement
> Reporter: Daniel Gómez Ferro
> Attachments: HBASE-4903.patch, HBASE-4903.patch
>
>
> The only way to return a result from RegionObserver.preIncrement() is to use Result.readFields() after serializing the correct result.
> This can be fixed either returning a Result object from that function or adding setters to Result. Another option is to modify the parameters and receive a List<KeyValue> as preGet() does.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira