[GitHub] fabianmenges commented on a change in pull request #3521: Time Series Annotation Layers

[gi...@git.apache.org]

fabianmenges commented on a change in pull request #3521: Time Series Annotation Layers
URL: https://github.com/apache/incubator-superset/pull/3521#discussion_r141050792
 
 

 ##########
 File path: superset/views/annotations.py
 ##########
 @@ -0,0 +1,59 @@
+from __future__ import absolute_import
+from __future__ import division
+from __future__ import print_function
+from __future__ import unicode_literals
+
+from flask_babel import gettext as __
+from flask_appbuilder.models.sqla.interface import SQLAInterface
+
+from superset.models.annotations import Annotation, AnnotationLayer
+from superset import appbuilder
+from .base import SupersetModelView, DeleteMixin
+
+
+class AnnotationModelView(SupersetModelView, DeleteMixin):  # noqa
 
 Review comment:
   How are annotations written to that table? If you cannot write them from within superset, why are you not thinking of them as just another datasource?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services