You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/06/22 09:26:45 UTC
[GitHub] [flink] guoweiM opened a new pull request #12737: [FLINK-17639][docs] Document which FileSystems are supported by the Streami…
guoweiM opened a new pull request #12737:
URL: https://github.com/apache/flink/pull/12737
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
This pull request documents which `FileSystem`s are supported by the `StreamingFileSink`.
## Brief change log
- *document which `FileSystem`s are supported by the `StreamingFileSink` in the streamingfile_sink.md*
## Verifying this change
This change is about documentation. So no test is needed.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12737: [FLINK-17639][docs] Document which FileSystems are supported by the Streami…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12737:
URL: https://github.com/apache/flink/pull/12737#issuecomment-647407770
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cccbc2294423fce32765002c73acbb06b5ed40a4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cccbc2294423fce32765002c73acbb06b5ed40a4",
"triggerType" : "PUSH"
}, {
"hash" : "ec2483d7dd2f9b5e20cdde4673c77eeaf377491b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ec2483d7dd2f9b5e20cdde4673c77eeaf377491b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cccbc2294423fce32765002c73acbb06b5ed40a4 UNKNOWN
* ec2483d7dd2f9b5e20cdde4673c77eeaf377491b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12737: [FLINK-17639][docs] Document which FileSystems are supported by the Streami…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12737:
URL: https://github.com/apache/flink/pull/12737#issuecomment-647407770
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cccbc2294423fce32765002c73acbb06b5ed40a4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cccbc2294423fce32765002c73acbb06b5ed40a4",
"triggerType" : "PUSH"
}, {
"hash" : "ec2483d7dd2f9b5e20cdde4673c77eeaf377491b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3902",
"triggerID" : "ec2483d7dd2f9b5e20cdde4673c77eeaf377491b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cccbc2294423fce32765002c73acbb06b5ed40a4 UNKNOWN
* ec2483d7dd2f9b5e20cdde4673c77eeaf377491b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3902)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] guoweiM commented on a change in pull request #12737: [FLINK-17639][docs] Document which FileSystems are supported by the Streami…
Posted by GitBox <gi...@apache.org>.
guoweiM commented on a change in pull request #12737:
URL: https://github.com/apache/flink/pull/12737#discussion_r443945110
##########
File path: docs/dev/connectors/streamfile_sink.zh.md
##########
@@ -705,6 +705,9 @@ Hadoop 2.7 之前的版本不支持这个方法，因此 Flink 会报异常。
<span class="label label-danger">重要提示 3</span>: Flink 以及 `StreamingFileSink` 不会覆盖已经提交的数据。因此如果尝试从一个包含 in-progress 文件的旧 checkpoint/savepoint 恢复，
且这些 in-progress 文件会被接下来的成功 checkpoint 提交，Flink 会因为无法找到 in-progress 文件而抛异常，从而恢复失败。
+<span class="label label-danger">重要提示 4</span>: Flink 以及 `StreamingFileSink` 不会覆盖已经提交的数据。因此如果尝试从一个包含 in-progress 文件的旧 checkpoint/savepoint 恢复，
Review comment:
You are right. :P
I think it might be the md preview plugin that leads to the problem.
I preview the result of the document using the md plugin. But after previewing it suspends the whole IntelliJ. I just kill the IntelliJ and commit the result and push the branch. :(( Maybe some changes are lost because of the killing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12737: [FLINK-17639][docs] Document which FileSystems are supported by the Streami…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12737:
URL: https://github.com/apache/flink/pull/12737#issuecomment-647407770
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cccbc2294423fce32765002c73acbb06b5ed40a4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cccbc2294423fce32765002c73acbb06b5ed40a4",
"triggerType" : "PUSH"
}, {
"hash" : "ec2483d7dd2f9b5e20cdde4673c77eeaf377491b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3902",
"triggerID" : "ec2483d7dd2f9b5e20cdde4673c77eeaf377491b",
"triggerType" : "PUSH"
}, {
"hash" : "f009270ba46fafe795a77626ed0acbb50389d4c2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3940",
"triggerID" : "f009270ba46fafe795a77626ed0acbb50389d4c2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cccbc2294423fce32765002c73acbb06b5ed40a4 UNKNOWN
* ec2483d7dd2f9b5e20cdde4673c77eeaf377491b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3902)
* f009270ba46fafe795a77626ed0acbb50389d4c2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3940)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] kl0u commented on a change in pull request #12737: [FLINK-17639][docs] Document which FileSystems are supported by the Streami…
Posted by GitBox <gi...@apache.org>.
kl0u commented on a change in pull request #12737:
URL: https://github.com/apache/flink/pull/12737#discussion_r443606522
##########
File path: docs/dev/connectors/streamfile_sink.md
##########
@@ -733,6 +733,9 @@ Given this, when trying to restore from an old checkpoint/savepoint which assume
by subsequent successful checkpoints, Flink will refuse to resume and it will throw an exception as it cannot locate the
in-progress file.
+<span class="label label-danger">Important Note 4</span>: Currently, the `StreamingFileSink` only supports three filesystems:
+HDFS/S3/Local. Flink will throw an exception when using an unsupported filesystem.
Review comment:
HDFS/S3/Local -> HDFS, S3, and Local
"Flink will throw an exception when using an unsupported filesystem **at runtime**." I would also add the "at runtime" part as this is the user-observed behaviour. This means that the job will start successfully but it will fail as soon as it tries to write some data.
##########
File path: docs/dev/connectors/streamfile_sink.zh.md
##########
@@ -705,6 +705,9 @@ Hadoop 2.7 之前的版本不支持这个方法，因此 Flink 会报异常。
<span class="label label-danger">重要提示 3</span>: Flink 以及 `StreamingFileSink` 不会覆盖已经提交的数据。因此如果尝试从一个包含 in-progress 文件的旧 checkpoint/savepoint 恢复，
且这些 in-progress 文件会被接下来的成功 checkpoint 提交，Flink 会因为无法找到 in-progress 文件而抛异常，从而恢复失败。
+<span class="label label-danger">重要提示 4</span>: Flink 以及 `StreamingFileSink` 不会覆盖已经提交的数据。因此如果尝试从一个包含 in-progress 文件的旧 checkpoint/savepoint 恢复，
Review comment:
Sorry for correcting you on the Chinese documentation, but this seems to be wrong as it looks like a copy of the point 3 above. I hope I am correct :P
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12737: [FLINK-17639][docs] Document which FileSystems are supported by the Streami…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12737:
URL: https://github.com/apache/flink/pull/12737#issuecomment-647407770
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cccbc2294423fce32765002c73acbb06b5ed40a4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cccbc2294423fce32765002c73acbb06b5ed40a4",
"triggerType" : "PUSH"
}, {
"hash" : "ec2483d7dd2f9b5e20cdde4673c77eeaf377491b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3902",
"triggerID" : "ec2483d7dd2f9b5e20cdde4673c77eeaf377491b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cccbc2294423fce32765002c73acbb06b5ed40a4 UNKNOWN
* ec2483d7dd2f9b5e20cdde4673c77eeaf377491b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3902)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12737: [FLINK-17639][docs] Document which FileSystems are supported by the Streami…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12737:
URL: https://github.com/apache/flink/pull/12737#issuecomment-647400075
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit cccbc2294423fce32765002c73acbb06b5ed40a4 (Mon Jun 22 09:29:54 UTC 2020)
**Warnings:**
* Documentation files were touched, but no `.zh.md` files: Update Chinese documentation or file Jira ticket.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12737: [FLINK-17639][docs] Document which FileSystems are supported by the Streami…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12737:
URL: https://github.com/apache/flink/pull/12737#issuecomment-647407770
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cccbc2294423fce32765002c73acbb06b5ed40a4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cccbc2294423fce32765002c73acbb06b5ed40a4",
"triggerType" : "PUSH"
}, {
"hash" : "ec2483d7dd2f9b5e20cdde4673c77eeaf377491b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3902",
"triggerID" : "ec2483d7dd2f9b5e20cdde4673c77eeaf377491b",
"triggerType" : "PUSH"
}, {
"hash" : "f009270ba46fafe795a77626ed0acbb50389d4c2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f009270ba46fafe795a77626ed0acbb50389d4c2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cccbc2294423fce32765002c73acbb06b5ed40a4 UNKNOWN
* ec2483d7dd2f9b5e20cdde4673c77eeaf377491b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3902)
* f009270ba46fafe795a77626ed0acbb50389d4c2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12737: [FLINK-17639][docs] Document which FileSystems are supported by the Streami…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12737:
URL: https://github.com/apache/flink/pull/12737#issuecomment-647407770
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cccbc2294423fce32765002c73acbb06b5ed40a4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cccbc2294423fce32765002c73acbb06b5ed40a4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cccbc2294423fce32765002c73acbb06b5ed40a4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12737: [FLINK-17639][docs] Document which FileSystems are supported by the Streami…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12737:
URL: https://github.com/apache/flink/pull/12737#issuecomment-647407770
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cccbc2294423fce32765002c73acbb06b5ed40a4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cccbc2294423fce32765002c73acbb06b5ed40a4",
"triggerType" : "PUSH"
}, {
"hash" : "ec2483d7dd2f9b5e20cdde4673c77eeaf377491b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3902",
"triggerID" : "ec2483d7dd2f9b5e20cdde4673c77eeaf377491b",
"triggerType" : "PUSH"
}, {
"hash" : "f009270ba46fafe795a77626ed0acbb50389d4c2",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3940",
"triggerID" : "f009270ba46fafe795a77626ed0acbb50389d4c2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cccbc2294423fce32765002c73acbb06b5ed40a4 UNKNOWN
* f009270ba46fafe795a77626ed0acbb50389d4c2 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3940)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] kl0u closed pull request #12737: [FLINK-17639][docs] Document which FileSystems are supported by the Streami…
Posted by GitBox <gi...@apache.org>.
kl0u closed pull request #12737:
URL: https://github.com/apache/flink/pull/12737
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org