[jira] Updated: (DERBY-3041) Merge the separate JDBC 2.0 and JDBC 3.0 implementations in the ij code (Main/Main14 and utilMain/utilMain14)

["Knut Anders Hatlen (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/DERBY-3041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Knut Anders Hatlen updated DERBY-3041:
--------------------------------------

    Attachment: d3041-1.stat
                d3041-1.diff

Attaching a patch which removes the classes Main14 and utilMain14. The createStatement() method in utilMain14 is moved to utilMain where it replaces a method with the same signature. The methods getHoldability() and setHoldability() are removed from utilMain, and their callers are modified to use Connection.setHoldability/getHoldability directly. The patch also removes an error message which is no longer in use after this change ("Holdability can not be changed using jdbc3.0 apis in JDKs lower than JDK1.4.")

Derbyall and suites.All ran cleanly on Sun JDK6.

> Merge the separate JDBC 2.0 and JDBC 3.0 implementations in the ij code (Main/Main14 and utilMain/utilMain14)
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3041
>                 URL: https://issues.apache.org/jira/browse/DERBY-3041
>             Project: Derby
>          Issue Type: Improvement
>          Components: Tools
>    Affects Versions: 10.4.0.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>            Priority: Minor
>         Attachments: d3041-1.diff, d3041-1.stat
>
>
> The classes utilMain and utilMain14 contain utility methods for manipulating the holdability of a connection or a statement. There is one implementation for JDBC 2.0 JVMs and one implementation for JDBC 3.0 JVMs. Since Derby now only supports JVMs which support JDBC 3.0 (or JSR-169 which is a subset of JDBC 3.0), we could move code from utilMain14 to utilMain and delete utilMain14. The class Main14 behaves identically to the class Main, except that it returns utilMain14 instances, so once the utilMain14 class is removed, Main14 can be removed as well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.