You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by cloud-fan <gi...@git.apache.org> on 2018/05/18 13:08:14 UTC

[GitHub] spark pull request #21361: [SPARK-24313][SQL] Fix collection operations' int...

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21361#discussion_r189262114
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala ---
    @@ -520,7 +523,12 @@ case class ArrayContains(left: Expression, right: Expression)
           TypeCheckResult.TypeCheckFailure(
             "Arguments must be an array followed by a value of same type as the array members")
         } else {
    -      TypeCheckResult.TypeCheckSuccess
    +      if (RowOrdering.isOrderable(right.dataType)) {
    --- End diff --
    
    we can call `TypeUtils.checkForOrderingExpr`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org