You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by "Ryota Egashira (JIRA)" <ji...@apache.org> on 2014/07/19 00:18:09 UTC
[jira] [Commented] (OOZIE-1933) SLACalculatorMemory HA changes
assume SLARegistrationBean exists for all jobs
[ https://issues.apache.org/jira/browse/OOZIE-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14066978#comment-14066978 ]
Ryota Egashira commented on OOZIE-1933:
---------------------------------------
+1 for unit_tests part
> SLACalculatorMemory HA changes assume SLARegistrationBean exists for all jobs
> -----------------------------------------------------------------------------
>
> Key: OOZIE-1933
> URL: https://issues.apache.org/jira/browse/OOZIE-1933
> Project: Oozie
> Issue Type: Bug
> Affects Versions: trunk
> Reporter: Mona Chitnis
> Assignee: Mona Chitnis
> Fix For: trunk
>
> Attachments: OOZIE-1933-3.patch, OOZIE-1933-4-1.patch, sla_unit_tests-1.patch, sla_unit_tests.patch
>
>
> SLACalculatorMemory.addJobStatus()
> {code}
> else {
> // jobid might not exist in slaMap in HA Setting
> SLARegistrationBean slaRegBean = SLARegistrationQueryExecutor.getInstance().get(
> SLARegQuery.GET_SLA_REG_ALL, jobId);
> SLASummaryBean slaSummaryBean = SLASummaryQueryExecutor.getInstance().get(SLASummaryQuery.GET_SLA_SUMMARY,
> jobId);
> slaCalc = new SLACalcStatus(slaSummaryBean, slaRegBean);
> {code}
> Because of SLA Listener, job notification event triggers this even for jobs with no SLA configured - leading to NPE in the SLACalcStatus constructor and annoying exception stacktraces in logs
> Patch to also include log prefix addition to some SLACalculator log line
--
This message was sent by Atlassian JIRA
(v6.2#6252)