[jira] [Commented] (GEODE-3386) Create Error type for KeyedErrorResponse and ErrorResponse

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-3386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120474#comment-16120474 ] 

ASF GitHub Bot commented on GEODE-3386:
---------------------------------------

GitHub user pivotal-amurmann opened a pull request:

    https://github.com/apache/geode/pull/700

    GEODE-3386 - Make KeyedErrorResponse & ErrorResponse siblings

    Thank you for submitting a contribution to Apache Geode.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    - [ ] Does `gradlew build` run cleanly?
    
    - [x] Have you written or updated unit tests to verify your changes?
    
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    N/A
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
    submit an update to your PR as soon as possible. If you need help, please send an
    email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pivotal-amurmann/geode feature/GEODE-3386

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/700.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #700
    
----
commit 81d7a34ef695738c61bf3d288b9ff01f054c30f5
Author: Alexander Murmann <am...@pivotal.io>
Date:   2017-08-09T18:52:17Z

    GEODE-3386 - Make KeyedErrorResponse & ErrorResponse siblings

----


> Create Error type for KeyedErrorResponse and ErrorResponse
> ----------------------------------------------------------
>
>                 Key: GEODE-3386
>                 URL: https://issues.apache.org/jira/browse/GEODE-3386
>             Project: Geode
>          Issue Type: Sub-task
>          Components: client/server
>            Reporter: Galen O'Sullivan
>
> For logical separation of the new client API, it will be better to have an Error that is contained by ErrorResponse, rather than having KeyedErrorResponse contain an ErrorResponse.
> In pseudo-protobuf,
> {code}
> PutAllResponse {
>   repeated Entry successes = 1,
>   repeated KeyedErrorResponse errors = 2,
> }
> KeyedErrorResponse {
>   Key,
>   ErrorResponse
> }
> ErrorResponse {
>   string
> }
> {code}
> instead,
> {code}
> KeyedErrorResponse {
>   Key,
>   Error,
> }
> {code}
> and 
> {code}
> ErrorResponse {
> Error
> }
> Error {
> string
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)