You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/03/30 23:25:03 UTC
[GitHub] [druid] clintropolis opened a new pull request #12382: complex metrics -> complex types
clintropolis opened a new pull request #12382:
URL: https://github.com/apache/druid/pull/12382
### Description
This PR rebrands `ComplexMetricSerde` as `ComplexTypeSerde`, `ComplexMetrics` as `ComplexTypes`, and `ComplexMetricExtractor` as `ComplexTypeExtractor`. All of the former are marked as deprecated, and their logic moved to (and implement) the latter to minimize disruption. All current serdes still implement `ComplexMetricSerde` rather than the new type, to allow anything using `ComplexMetrics.getSerdeForType` to continue functioning until their future removal, at which point the implementations shall be moved to extend `ComplexTypeSerde` directly.
I tested that this change is minimally disruptive by doing some tests using extensions (datasketches specifically, for my complex types) built against the master branch without the changes in this PR, and everything was still functioning correctly as far as I can tell, so I think it should be relatively chill despite changing stuff marked `@ExtensionPoint`.
This PR has:
- [x] been self-reviewed.
- [x] added documentation for new or modified features or behaviors.
- [x] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [x] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on pull request #12382: complex metrics -> complex types
Posted by GitBox <gi...@apache.org>.
clintropolis commented on pull request #12382:
URL: https://github.com/apache/druid/pull/12382#issuecomment-1084035567
this is failing code coverage for `druid-processing` because the majority of the implementations are in extensions and no new code was added to require adding new tests.. will see how painful it is to add to see what I can do, but I don't think it should block this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis closed pull request #12382: complex metrics -> complex types
Posted by GitBox <gi...@apache.org>.
clintropolis closed pull request #12382:
URL: https://github.com/apache/druid/pull/12382
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on pull request #12382: complex metrics -> complex types
Posted by GitBox <gi...@apache.org>.
clintropolis commented on pull request #12382:
URL: https://github.com/apache/druid/pull/12382#issuecomment-1085015717
>Additionally, reading through all of those methods reminded me of the methods that I wish didn't exist on ComplexMetricSerde. I'm sad that some of them are continuing their life into ComplexTypeSerde, but it's not worth it to introduce backwards incompatibility just for a rename.
Thinking more about this, I've decided to just close this PR in favor of doing something cooler in the future so we can just rework `ComplexMetricSerde` completely as something new.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org