[GitHub] [arrow-rs] crepererum commented on a diff in pull request #3788: refactor: assorted `FlightSqlServiceClient` improvements

["crepererum (via GitHub)" <gi...@apache.org>]

crepererum commented on code in PR #3788:
URL: https://github.com/apache/arrow-rs/pull/3788#discussion_r1123256026


##########
arrow-flight/src/sql/client.rs:
##########
@@ -83,13 +75,23 @@ impl FlightSqlServiceClient {
 
     /// Creates a new HTTPs FlightSql Client that connects via TCP to a server
     #[cfg(feature = "tls")]
-    pub async fn new_with_endpoint(
-        client_ident: Identity,
-        server_ca: Certificate,
-        domain: &str,
+    pub async fn new_with_tls_endpoint(

Review Comment:
   At the moment we also use a very opinionated `Endpoint` config (see `fn endpoint`). If we keep that then I would at least like to offer a way to configure a TLS client that is in line with that presets. However we may also just remove the opinionated endpoint setup altogether and ONLY present a single constructor that takes `channel`. WDYT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org