You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/04/03 04:10:11 UTC
Review Request 19982: Allowed IP and MAC to be created from u32 value and
byte array.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19982/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Chi Zhang, Ian Downes, Vinod Kone, and Cong Wang.
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 42819ab
Diff: https://reviews.apache.org/r/19982/diff/
Testing
-------
Trivial.
Thanks,
Jie Yu
Re: Review Request 19982: Allowed IP and MAC to be created from u32 value
and byte array.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19982/#review39425
-----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp
<https://reviews.apache.org/r/19982/#comment71828>
this would be safer as a std::vector<uint8_t> so you could check the size.
- Dominic Hamon
On April 2, 2014, 7:10 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19982/
> -----------------------------------------------------------
>
> (Updated April 2, 2014, 7:10 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Chi Zhang, Ian Downes, Vinod Kone, and Cong Wang.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 42819ab
>
> Diff: https://reviews.apache.org/r/19982/diff/
>
>
> Testing
> -------
>
> Trivial.
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 19982: Adjusted constructors of net::IP and net::MAC.
Posted by Jie Yu <yu...@gmail.com>.
> On April 9, 2014, 9:32 p.m., Vinod Kone wrote:
> > Just to be sure, this new IP address format is not being used by libprocess yet?
Yes, it's only used by the routing library. I will cleanup libprocess/mesos later as it's a bug (tracked in https://issues.apache.org/jira/browse/MESOS-1201).
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19982/#review39933
-----------------------------------------------------------
On April 9, 2014, 7:42 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19982/
> -----------------------------------------------------------
>
> (Updated April 9, 2014, 7:42 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Chi Zhang, Ian Downes, Vinod Kone, and Cong Wang.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary. We also store IP addresses in "host order" now (instead of network order). See the following ticket for details:
> https://issues.apache.org/jira/browse/MESOS-1201
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 9e81271
> 3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp 04fd5a2
>
> Diff: https://reviews.apache.org/r/19982/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 19982: Adjusted constructors of net::IP and net::MAC.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19982/#review39933
-----------------------------------------------------------
Ship it!
Just to be sure, this new IP address format is not being used by libprocess yet?
- Vinod Kone
On April 9, 2014, 7:42 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19982/
> -----------------------------------------------------------
>
> (Updated April 9, 2014, 7:42 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Chi Zhang, Ian Downes, Vinod Kone, and Cong Wang.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary. We also store IP addresses in "host order" now (instead of network order). See the following ticket for details:
> https://issues.apache.org/jira/browse/MESOS-1201
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 9e81271
> 3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp 04fd5a2
>
> Diff: https://reviews.apache.org/r/19982/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 19982: Adjusted constructors of net::IP and net::MAC.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19982/
-----------------------------------------------------------
(Updated April 9, 2014, 7:42 p.m.)
Review request for mesos, Benjamin Hindman, Chi Zhang, Ian Downes, Vinod Kone, and Cong Wang.
Changes
-------
Dominic's comments. Stored IP addresses in host order.
Summary (updated)
-----------------
Adjusted constructors of net::IP and net::MAC.
Repository: mesos-git
Description (updated)
-------
See summary. We also store IP addresses in "host order" now (instead of network order). See the following ticket for details:
https://issues.apache.org/jira/browse/MESOS-1201
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 9e81271
3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp 04fd5a2
Diff: https://reviews.apache.org/r/19982/diff/
Testing (updated)
-------
make check
Thanks,
Jie Yu