You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by bt...@apache.org on 2019/11/15 02:41:29 UTC
[james-project] 20/30: [Refactoring] Fix softly assertions coding
style on backend-cassandra module
This is an automated email from the ASF dual-hosted git repository.
btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git
commit c21d5f8cf86edeb4b5b57757a5da69f76f0ea7cd
Author: Rene Cordier <rc...@linagora.com>
AuthorDate: Tue Nov 12 17:00:42 2019 +0700
[Refactoring] Fix softly assertions coding style on backend-cassandra module
---
.../cassandra/init/CassandraConfigurationTest.java | 29 +++++++++++-----------
1 file changed, 14 insertions(+), 15 deletions(-)
diff --git a/backends-common/cassandra/src/test/java/org/apache/james/backends/cassandra/init/CassandraConfigurationTest.java b/backends-common/cassandra/src/test/java/org/apache/james/backends/cassandra/init/CassandraConfigurationTest.java
index a97e852..678b7f7 100644
--- a/backends-common/cassandra/src/test/java/org/apache/james/backends/cassandra/init/CassandraConfigurationTest.java
+++ b/backends-common/cassandra/src/test/java/org/apache/james/backends/cassandra/init/CassandraConfigurationTest.java
@@ -23,15 +23,12 @@ import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatThrownBy;
import org.apache.james.backends.cassandra.init.configuration.CassandraConfiguration;
-import org.assertj.core.api.JUnitJupiterSoftAssertions;
+import org.assertj.core.api.SoftAssertions;
import org.junit.jupiter.api.Test;
-import org.junit.jupiter.api.extension.RegisterExtension;
import nl.jqno.equalsverifier.EqualsVerifier;
class CassandraConfigurationTest {
- @RegisterExtension
- JUnitJupiterSoftAssertions softly = new JUnitJupiterSoftAssertions();
@Test
void cassandraConfigurationShouldRespectBeanContract() {
@@ -213,17 +210,19 @@ class CassandraConfigurationTest {
.messageAttachmentIdsReadTimeout(messageAttachmentIdReadTimeout)
.build();
- softly.assertThat(configuration.getAclMaxRetry()).isEqualTo(aclMaxRetry);
- softly.assertThat(configuration.getModSeqMaxRetry()).isEqualTo(modSeqMaxRetry);
- softly.assertThat(configuration.getUidMaxRetry()).isEqualTo(uidMaxRetry);
- softly.assertThat(configuration.getFetchNextPageInAdvanceRow()).isEqualTo(fetchNextPageInAdvanceRow);
- softly.assertThat(configuration.getFlagsUpdateMessageMaxRetry()).isEqualTo(flagsUpdateMessageMaxRetry);
- softly.assertThat(configuration.getFlagsUpdateMessageIdMaxRetry()).isEqualTo(flagsUpdateMessageIdMaxRetry);
- softly.assertThat(configuration.getMessageReadChunkSize()).isEqualTo(messageReadChunkSize);
- softly.assertThat(configuration.getExpungeChunkSize()).isEqualTo(expungeChunkSize);
- softly.assertThat(configuration.getBlobPartSize()).isEqualTo(blobPartSize);
- softly.assertThat(configuration.getAttachmentV2MigrationReadTimeout()).isEqualTo(attachmentV2MigrationReadTimeout);
- softly.assertThat(configuration.getMessageAttachmentIdsReadTimeout()).isEqualTo(messageAttachmentIdReadTimeout);
+ SoftAssertions.assertSoftly(softly -> {
+ softly.assertThat(configuration.getAclMaxRetry()).isEqualTo(aclMaxRetry);
+ softly.assertThat(configuration.getModSeqMaxRetry()).isEqualTo(modSeqMaxRetry);
+ softly.assertThat(configuration.getUidMaxRetry()).isEqualTo(uidMaxRetry);
+ softly.assertThat(configuration.getFetchNextPageInAdvanceRow()).isEqualTo(fetchNextPageInAdvanceRow);
+ softly.assertThat(configuration.getFlagsUpdateMessageMaxRetry()).isEqualTo(flagsUpdateMessageMaxRetry);
+ softly.assertThat(configuration.getFlagsUpdateMessageIdMaxRetry()).isEqualTo(flagsUpdateMessageIdMaxRetry);
+ softly.assertThat(configuration.getMessageReadChunkSize()).isEqualTo(messageReadChunkSize);
+ softly.assertThat(configuration.getExpungeChunkSize()).isEqualTo(expungeChunkSize);
+ softly.assertThat(configuration.getBlobPartSize()).isEqualTo(blobPartSize);
+ softly.assertThat(configuration.getAttachmentV2MigrationReadTimeout()).isEqualTo(attachmentV2MigrationReadTimeout);
+ softly.assertThat(configuration.getMessageAttachmentIdsReadTimeout()).isEqualTo(messageAttachmentIdReadTimeout);
+ });
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org