[GitHub] [accumulo] milleruntime commented on a change in pull request #1774: Refactor Tablet state classes

[GitBox <gi...@apache.org>]

milleruntime commented on a change in pull request #1774:
URL: https://github.com/apache/accumulo/pull/1774#discussion_r522266607



##########
File path: core/src/main/java/org/apache/accumulo/core/clientImpl/TableOperationsImpl.java
##########
@@ -1301,7 +1301,7 @@ private void waitForTableStateTransition(TableId tableId, TableState expectedSta
           lastRow = tablet.getExtent().toMetaRow();
 
           if (loc != null) {
-            serverCounts.increment(loc.getId(), 1);
+            serverCounts.increment(loc.toString(), 1);

Review comment:
       They should be returning the same thing, but I don't think either method name is appropriate.  Looking at the impl, they both ultimately return `hostPort() + "[" + session + "]"`.  
   
   Maybe something very explicit like `getHostPortSession()` would be better.  Then it will be clear what parts of the code we need to change if we drop/change the session.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org