You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "keith-turner (via GitHub)" <gi...@apache.org> on 2023/11/17 17:23:43 UTC
[PR] Replaces java constant name with value in metrics javadocs [accumulo]
keith-turner opened a new pull request, #3956:
URL: https://github.com/apache/accumulo/pull/3956
The metrics javadocs, which are referenced from the user manual, have a table that currently contains java constant names. From the perspective of a user they would probably prefer the value of the java constant, which is currently cumbersome to obtain. This commit replaces the java constant name with the values in the javadoc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Replaces java constant name with value in metrics javadocs [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on PR #3956:
URL: https://github.com/apache/accumulo/pull/3956#issuecomment-1816874530
> Can you show what it looks like when processed / rendered? (Just to make sure it works as expected) Otherwise, LGTM
My IDE has an option to preview javadoc and that looked ok. I would like to build it and see what it looks like, but not sure how to make maven build the javadocs.
This is what the current javadocs look like before this change :
https://www.javadoc.io/doc/org.apache.accumulo/accumulo-core/2.1.2/org/apache/accumulo/core/metrics/MetricsProducer.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Replaces java constant name with value in metrics javadocs [accumulo]
Posted by "EdColeman (via GitHub)" <gi...@apache.org>.
EdColeman commented on PR #3956:
URL: https://github.com/apache/accumulo/pull/3956#issuecomment-1816857435
Can you show what it looks like when processed / rendered? (Just to make sure it works as expected) Otherwise, LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Replaces java constant name with value in metrics javadocs [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner merged PR #3956:
URL: https://github.com/apache/accumulo/pull/3956
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org