[jira] [Commented] (MESOS-5428) Update the mechanism to define flags in FlagsBase derived clases

["Michael Park (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-5428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15368311#comment-15368311 ] 

Michael Park commented on MESOS-5428:
-------------------------------------

https://reviews.apache.org/r/47671/

> Update the mechanism to define flags in FlagsBase derived clases
> ----------------------------------------------------------------
>
>                 Key: MESOS-5428
>                 URL: https://issues.apache.org/jira/browse/MESOS-5428
>             Project: Mesos
>          Issue Type: Bug
>            Reporter: Daniel Pravat
>
> If a program exeposes flags,  the recommendation from Mesos was to use a derived class from FlagsBase, add the new flags in constructor.
> As benefit  the new `Flags` class `inherits` all the flags from the derived classes.
> Each derived calss calls the method `add` implemented in `FlagsBase` which uses `dynamic_cast` to set the default value and other things.
> To use `FlagsBase` derived classes in Visual Studio  we should disable construction displacements using `/vd2` compile option. 
> More info: https://msdn.microsoft.com/en-us/library/7sf3txa8.aspx



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)