You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/05/17 17:29:33 UTC
[GitHub] [arrow-rs] tustvold opened a new pull request, #4238: Remove AWS_PROFILE support
tustvold opened a new pull request, #4238:
URL: https://github.com/apache/arrow-rs/pull/4238
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #4137
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
The experimental support for `AWS_PROFILE` was always rather tacked on, and didn't really behave correctly. Following #4235 we have a much better story for allowing people to explicitly opt-in to the credentials semantics they want. See https://github.com/apache/arrow-datafusion/pull/6374/files#diff-a5c802a601097328bd118178abf20383d6002d1750733abef0c7d34e1832c340 for an example of what this looks like.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on a diff in pull request #4238: Remove AWS_PROFILE support
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #4238:
URL: https://github.com/apache/arrow-rs/pull/4238#discussion_r1197000289
##########
object_store/Cargo.toml:
##########
@@ -53,11 +53,6 @@ reqwest = { version = "0.11", default-features = false, features = ["rustls-tls"
ring = { version = "0.16", default-features = false, features = ["std"], optional = true }
rustls-pemfile = { version = "1.0", default-features = false, optional = true }
-# AWS Profile support
Review Comment:
I did some archeology and turns out this was added in https://github.com/apache/arrow-rs/pull/2891 -- looks like @timvw @wjones127 and @roeap may be interested so tagging them as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove AWS_PROFILE support [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #4238:
URL: https://github.com/apache/arrow-rs/pull/4238#issuecomment-2343152594
I don't see any places within the docs that still refer to AWS_PROFILE, however, documentation improvement PRs are always welcome
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #4238: Remove AWS_PROFILE support
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #4238:
URL: https://github.com/apache/arrow-rs/pull/4238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove AWS_PROFILE support [arrow-rs]
Posted by "Lundez (via GitHub)" <gi...@apache.org>.
Lundez commented on PR #4238:
URL: https://github.com/apache/arrow-rs/pull/4238#issuecomment-2343148569
@tustvold the docs are not updated to say that AWS_PROFILE is unsupported. I was confused trying to use AWS_PROFILE today...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org