You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org> on 2011/09/01 18:42:12 UTC

[jira] [Commented] (ZOOKEEPER-1107) automating log and snapshot cleaning

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095396#comment-13095396 ] 

jiraposter@reviews.apache.org commented on ZOOKEEPER-1107:
----------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1043/
-----------------------------------------------------------

(Updated 2011-09-01 16:40:46.185217)


Review request for zookeeper, Patrick Hunt, Benjamin Reed, and Mahadev Konar.


Changes
-------

updated to 1107.5 patch


Summary
-------

I like to have ZK itself manage the amount of snapshots and logs kept, instead of relying on the PurgeTxnLog utility.


This addresses bug ZOOKEEPER-1107.
    https://issues.apache.org/jira/browse/ZOOKEEPER-1107


Diffs (updated)
-----

  ./src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java 1149082 
  ./src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java 1149082 
  ./src/java/main/org/apache/zookeeper/server/DatadirCleanupManager.java PRE-CREATION 
  ./conf/zoo_sample.cfg 1149082 
  ./src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml 1149082 
  ./src/java/test/org/apache/zookeeper/server/DatadirCleanupManagerTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/1043/diff


Testing
-------

test added, passing hudson qa bot.


Thanks,

Patrick



> automating log and snapshot cleaning
> ------------------------------------
>
>                 Key: ZOOKEEPER-1107
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1107
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: server
>    Affects Versions: 3.3.3
>            Reporter: Jun Rao
>            Assignee: Laxman
>         Attachments: ZOOKEEPER-1107.1.patch, ZOOKEEPER-1107.2.patch, ZOOKEEPER-1107.3.patch, ZOOKEEPER-1107.4.patch, ZOOKEEPER-1107.5.patch, ZOOKEEPER-1107.5.patch, ZOOKEEPER-1107.patch
>
>
> I like to have ZK itself manage the amount of snapshots and logs kept,  instead of relying on the PurgeTxnLog utility.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira