[GitHub] [pulsar] sijie edited a comment on issue #4018: Support multi-host for pulsar-admin

[GitBox <gi...@apache.org>]

sijie edited a comment on issue #4018: Support multi-host for pulsar-admin
URL: https://github.com/apache/pulsar/pull/4018#issuecomment-492408596
 
 
   > The PR changed the behavior from fail immediately to fail later, even when using a single endpoint.
   
   If "fail immediately" means fail if not connect, that's probably the case. but that should be respect to connect timeout anyway. The whole problem was raised is because of the commit in #4235 since it raises the default value from 60s to 5 mins.
   
   The PR here is to handle multiple hosts, where each host is using 1/3 of the request timeout as its request timeout. 
   
   > That's a completely different question from the multi-host vs single-host though.
   
   I am not sure how it is different between multi-host or single host. from end-user perspective, if he sets a request timeout, he expects the request timeout within the provided timeout period no matter it is a multi-host or a single host request. From the end-user experience, I don't see how this PR make a difference. It is actually honoring to the request timeout setting that user provides.
   
   I agreed that this PR can be improved with changes in async paths, adding backoffs or other improvements you highlighted. but this PR doesn't change the contract that pulsar admin cli draws with users. 
   
   If it is the request timeout contract required discussions, then we should probably discuss it in #4235. 
   
   > While that could be nice, the application would have to be prepared anyway to handle the errors, so it won't simplify their logic there.
   
   sure. but at least it gives much better experiences for users who using admin api library.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services