You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/08/28 03:01:21 UTC

[GitHub] [arrow] sagnikc-dremio commented on pull request #7885: ARROW-9640: [C++][Gandiva] Implement round() for integers and long integers

sagnikc-dremio commented on pull request #7885:
URL: https://github.com/apache/arrow/pull/7885#issuecomment-682297850


   > With the two changes mentioned round_int32_int32 can be vectorized.
   > 
   > https://godbolt.org/z/fabEn6
   > 
   > With LLVM it actually doesn't necessarily seem to matter.
   
   With the vectorized round_int32_int32, why are we passing -5 as the second argument? Would be glad if you could clarify.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org