You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "cloud-fan (via GitHub)" <gi...@apache.org> on 2023/09/18 03:32:05 UTC

[GitHub] [spark] cloud-fan commented on a diff in pull request #42957: [SPARK-45188][SQL][DOCS] Update error messages related to parameterized `sql()`

cloud-fan commented on code in PR #42957:
URL: https://github.com/apache/spark/pull/42957#discussion_r1328222789


##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -1892,7 +1892,7 @@
   },
   "INVALID_SQL_ARG" : {
     "message" : [
-      "The argument <name> of `sql()` is invalid. Consider to replace it by a SQL literal."
+      "The argument <name> of `sql()` is invalid. Consider to replace it either by a SQL literal or by a map constructed by `map()`, `map_from_arrays()`, `map_from_entries()`, or by an array constructed by `array()`. Also such functions can be invoked via `call_function()`."

Review Comment:
   maybe just say `collection constructor functions such as map(), array(), struct()`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org