You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Peter Rozsa (Code Review)" <ge...@cloudera.org> on 2023/03/20 14:03:53 UTC
[Impala-ASF-CR] IMPALA-12003: Make getPartialCatalogObject logging silent
Peter Rozsa has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19627
Change subject: IMPALA-12003: Make getPartialCatalogObject logging silent
......................................................................
IMPALA-12003: Make getPartialCatalogObject logging silent
This patch changes the getPartialCatalogObject catalog operation
to use the silent execution path.
The silent execution path is now logging in trace level, making it
possible to track start-stop events for silent operations.
Change-Id: I45e331eb299c057c2fdc6a3c2ed7e4ed6d1f40b7
---
M fe/src/main/java/org/apache/impala/common/JniUtil.java
M fe/src/main/java/org/apache/impala/service/JniCatalog.java
2 files changed, 14 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/19627/2
--
To view, visit http://gerrit.cloudera.org:8080/19627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I45e331eb299c057c2fdc6a3c2ed7e4ed6d1f40b7
Gerrit-Change-Number: 19627
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-12003: Make getPartialCatalogObject logging silent
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19627 )
Change subject: IMPALA-12003: Make getPartialCatalogObject logging silent
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12648/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I45e331eb299c057c2fdc6a3c2ed7e4ed6d1f40b7
Gerrit-Change-Number: 19627
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 20 Mar 2023 14:24:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12003: Make getPartialCatalogObject logging silent
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19627 )
Change subject: IMPALA-12003: Make getPartialCatalogObject logging silent
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Let's wait in case Quanlong would like to review it too.
http://gerrit.cloudera.org:8080/#/c/19627/3/fe/src/main/java/org/apache/impala/common/JniUtil.java
File fe/src/main/java/org/apache/impala/common/JniUtil.java:
http://gerrit.cloudera.org:8080/#/c/19627/3/fe/src/main/java/org/apache/impala/common/JniUtil.java@174
PS3, Line 174: PrintUtils.printTimeMs
We could also extract it before the IF as it is the same in both branches.
--
To view, visit http://gerrit.cloudera.org:8080/19627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I45e331eb299c057c2fdc6a3c2ed7e4ed6d1f40b7
Gerrit-Change-Number: 19627
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 21 Mar 2023 11:04:14 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12003: Make getPartialCatalogObject logging silent
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19627 )
Change subject: IMPALA-12003: Make getPartialCatalogObject logging silent
......................................................................
Patch Set 2:
(2 comments)
Thanks Peter! Looks good.
http://gerrit.cloudera.org:8080/#/c/19627/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19627/2//COMMIT_MSG@11
PS2, Line 11: logging in trace level
Could mention that it used to not log at all, to provide some context.
http://gerrit.cloudera.org:8080/#/c/19627/2/fe/src/main/java/org/apache/impala/common/JniUtil.java
File fe/src/main/java/org/apache/impala/common/JniUtil.java:
http://gerrit.cloudera.org:8080/#/c/19627/2/fe/src/main/java/org/apache/impala/common/JniUtil.java@146
PS2, Line 146: public static class OperationLog {
I'm not sure it's worth putting these here as they are only used in their respective functions. I think START_FORMAT could be used inline as it used to be and FINISH_FORMAT could be a local constant in logFinish(). This would also improve the local readability of these functions.
--
To view, visit http://gerrit.cloudera.org:8080/19627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I45e331eb299c057c2fdc6a3c2ed7e4ed6d1f40b7
Gerrit-Change-Number: 19627
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 20 Mar 2023 14:12:21 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12003: Make getPartialCatalogObject logging silent
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19627 )
Change subject: IMPALA-12003: Make getPartialCatalogObject logging silent
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12657/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I45e331eb299c057c2fdc6a3c2ed7e4ed6d1f40b7
Gerrit-Change-Number: 19627
Gerrit-PatchSet: 4
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 21 Mar 2023 12:48:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12003: Make getPartialCatalogObject logging silent
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19627 )
Change subject: IMPALA-12003: Make getPartialCatalogObject logging silent
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I45e331eb299c057c2fdc6a3c2ed7e4ed6d1f40b7
Gerrit-Change-Number: 19627
Gerrit-PatchSet: 5
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 21 Mar 2023 17:40:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12003: Make getPartialCatalogObject logging silent
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19627 )
Change subject: IMPALA-12003: Make getPartialCatalogObject logging silent
......................................................................
IMPALA-12003: Make getPartialCatalogObject logging silent
This patch changes the getPartialCatalogObject catalog operation
to use the silent execution path. The silent execution path is now
logging in trace level instead of suppressing the logging at all, making
it possible to track start-stop events for silent operations.
Change-Id: I45e331eb299c057c2fdc6a3c2ed7e4ed6d1f40b7
Reviewed-on: http://gerrit.cloudera.org:8080/19627
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/common/JniUtil.java
M fe/src/main/java/org/apache/impala/service/JniCatalog.java
2 files changed, 13 insertions(+), 7 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/19627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I45e331eb299c057c2fdc6a3c2ed7e4ed6d1f40b7
Gerrit-Change-Number: 19627
Gerrit-PatchSet: 6
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-12003: Make getPartialCatalogObject logging silent
Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/19627 )
Change subject: IMPALA-12003: Make getPartialCatalogObject logging silent
......................................................................
IMPALA-12003: Make getPartialCatalogObject logging silent
This patch changes the getPartialCatalogObject catalog operation
to use the silent execution path. The silent execution path is now
logging in trace level instead of suppressing the logging at all, making
it possible to track start-stop events for silent operations.
Change-Id: I45e331eb299c057c2fdc6a3c2ed7e4ed6d1f40b7
---
M fe/src/main/java/org/apache/impala/common/JniUtil.java
M fe/src/main/java/org/apache/impala/service/JniCatalog.java
2 files changed, 13 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/19627/4
--
To view, visit http://gerrit.cloudera.org:8080/19627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I45e331eb299c057c2fdc6a3c2ed7e4ed6d1f40b7
Gerrit-Change-Number: 19627
Gerrit-PatchSet: 4
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-12003: Make getPartialCatalogObject logging silent
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19627 )
Change subject: IMPALA-12003: Make getPartialCatalogObject logging silent
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12653/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I45e331eb299c057c2fdc6a3c2ed7e4ed6d1f40b7
Gerrit-Change-Number: 19627
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 21 Mar 2023 07:56:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12003: Make getPartialCatalogObject logging silent
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19627 )
Change subject: IMPALA-12003: Make getPartialCatalogObject logging silent
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9161/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/19627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I45e331eb299c057c2fdc6a3c2ed7e4ed6d1f40b7
Gerrit-Change-Number: 19627
Gerrit-PatchSet: 5
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 21 Mar 2023 12:29:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12003: Make getPartialCatalogObject logging silent
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19627 )
Change subject: IMPALA-12003: Make getPartialCatalogObject logging silent
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I45e331eb299c057c2fdc6a3c2ed7e4ed6d1f40b7
Gerrit-Change-Number: 19627
Gerrit-PatchSet: 5
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 21 Mar 2023 12:29:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12003: Make getPartialCatalogObject logging silent
Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/19627 )
Change subject: IMPALA-12003: Make getPartialCatalogObject logging silent
......................................................................
Patch Set 3:
(2 comments)
Thank you, Daniel!
http://gerrit.cloudera.org:8080/#/c/19627/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19627/2//COMMIT_MSG@11
PS2, Line 11: suppressing the loggi
> Could mention that it used to not log at all, to provide some context.
Done
http://gerrit.cloudera.org:8080/#/c/19627/2/fe/src/main/java/org/apache/impala/common/JniUtil.java
File fe/src/main/java/org/apache/impala/common/JniUtil.java:
http://gerrit.cloudera.org:8080/#/c/19627/2/fe/src/main/java/org/apache/impala/common/JniUtil.java@146
PS2, Line 146: public static class OperationLog {
> I'm not sure it's worth putting these here as they are only used in their r
Done
--
To view, visit http://gerrit.cloudera.org:8080/19627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I45e331eb299c057c2fdc6a3c2ed7e4ed6d1f40b7
Gerrit-Change-Number: 19627
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 21 Mar 2023 07:35:22 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12003: Make getPartialCatalogObject logging silent
Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/19627 )
Change subject: IMPALA-12003: Make getPartialCatalogObject logging silent
......................................................................
IMPALA-12003: Make getPartialCatalogObject logging silent
This patch changes the getPartialCatalogObject catalog operation
to use the silent execution path. The silent execution path is now
logging in trace level instead of suppressing the logging at all, making
it possible to track start-stop events for silent operations.
Change-Id: I45e331eb299c057c2fdc6a3c2ed7e4ed6d1f40b7
---
M fe/src/main/java/org/apache/impala/common/JniUtil.java
M fe/src/main/java/org/apache/impala/service/JniCatalog.java
2 files changed, 14 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/19627/3
--
To view, visit http://gerrit.cloudera.org:8080/19627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I45e331eb299c057c2fdc6a3c2ed7e4ed6d1f40b7
Gerrit-Change-Number: 19627
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>