You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Chris Wewerka (JIRA)" <ji...@apache.org> on 2010/12/27 10:02:46 UTC
[jira] Created: (WICKET-3284) Feedback messages are not displayed
permanently when using REDIRECT_TO_BUFFER
Feedback messages are not displayed permanently when using REDIRECT_TO_BUFFER
-----------------------------------------------------------------------------
Key: WICKET-3284
URL: https://issues.apache.org/jira/browse/WICKET-3284
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.4.14
Reporter: Chris Wewerka
In our app someone used ONE_PASS_RENDER to bypass/workaround problems with the redirect-after-post pattern in a Apache/Tomcat scenario where the app was not mounted under root path in tomcat, but was mounted under root path in the apache. I figured out the problems with missing rewrite rules.
Then I switched back to the default: REDIRECT_TO_BUFFER
But now I have s.th. that I think is a bug: If I post a form, I get a response with a redirect and all errors/feedback messages are displayed correctly. But if I reload the page again a GET to the very same page is done, but the feedback messages are gone. Shouldn't the messages also be stored in the buffer and should be correctly displayed if the page with its state is redisplayed?
I've also found out that this isn't only a behaviour in our app, but can also be found e.g. here in the CDAPP Example: http://www.wicket-library.com/wicket-contrib-examples/cdapp
Just select one CD, delete title for example, press save and you're presented some error feedback. But when you hit "reload", the messages are gone. IMHO the state of the page including the feedback messages should be presented to the user.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3284) Feedback messages are not displayed
permanently when using REDIRECT_TO_BUFFER
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12975562#action_12975562 ]
Martin Grigorov commented on WICKET-3284:
-----------------------------------------
Chris, the buffer is read and immediately delete just once.
It works this way - in the first request Wicket generates the component tree and renders it to a buffered response, then it sends a redirect to the user agent and when the redirect comes back Wicket just flushes the buffered response into the http servlet response and deletes the buffered response from its temporary storage.
Pressing "Reload/F5" restarts the whole process.
BTW afair www.wicket-library.com is quite out-dated. I'll notify its admin.
> Feedback messages are not displayed permanently when using REDIRECT_TO_BUFFER
> -----------------------------------------------------------------------------
>
> Key: WICKET-3284
> URL: https://issues.apache.org/jira/browse/WICKET-3284
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.14
> Reporter: Chris Wewerka
>
> In our app someone used ONE_PASS_RENDER to bypass/workaround problems with the redirect-after-post pattern in a Apache/Tomcat scenario where the app was not mounted under root path in tomcat, but was mounted under root path in the apache. I figured out the problems with missing rewrite rules.
> Then I switched back to the default: REDIRECT_TO_BUFFER
> But now I have s.th. that I think is a bug: If I post a form, I get a response with a redirect and all errors/feedback messages are displayed correctly. But if I reload the page again a GET to the very same page is done, but the feedback messages are gone. Shouldn't the messages also be stored in the buffer and should be correctly displayed if the page with its state is redisplayed?
> I've also found out that this isn't only a behaviour in our app, but can also be found e.g. here in the CDAPP Example: http://www.wicket-library.com/wicket-contrib-examples/cdapp
> Just select one CD, delete title for example, press save and you're presented some error feedback. But when you hit "reload", the messages are gone. IMHO the state of the page including the feedback messages should be presented to the user.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-3284) Feedback messages are not displayed
permanently when using REDIRECT_TO_BUFFER
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-3284.
-----------------------------------
Resolution: Invalid
Assignee: Igor Vaynberg
feedback messages are cleared after they are rendered, no matter which strategy you use. refreshing the page with the form does not process the form so the messages are gone, which makes sense.
> Feedback messages are not displayed permanently when using REDIRECT_TO_BUFFER
> -----------------------------------------------------------------------------
>
> Key: WICKET-3284
> URL: https://issues.apache.org/jira/browse/WICKET-3284
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.14
> Reporter: Chris Wewerka
> Assignee: Igor Vaynberg
>
> In our app someone used ONE_PASS_RENDER to bypass/workaround problems with the redirect-after-post pattern in a Apache/Tomcat scenario where the app was not mounted under root path in tomcat, but was mounted under root path in the apache. I figured out the problems with missing rewrite rules.
> Then I switched back to the default: REDIRECT_TO_BUFFER
> But now I have s.th. that I think is a bug: If I post a form, I get a response with a redirect and all errors/feedback messages are displayed correctly. But if I reload the page again a GET to the very same page is done, but the feedback messages are gone. Shouldn't the messages also be stored in the buffer and should be correctly displayed if the page with its state is redisplayed?
> I've also found out that this isn't only a behaviour in our app, but can also be found e.g. here in the CDAPP Example: http://www.wicket-library.com/wicket-contrib-examples/cdapp
> Just select one CD, delete title for example, press save and you're presented some error feedback. But when you hit "reload", the messages are gone. IMHO the state of the page including the feedback messages should be presented to the user.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.